feat(dashboard): chart customizations modal and plugins by DamianPendrak · Pull Request #36062 · apache/superset

DamianPendrak · 2025-11-10T23:45:48Z

User description

SUMMARY

Adds Chart Customizations to the "Edit filters" modal. Time Grain and Time Column moved from Filters to the Chart Customizations. Chart Customizations can now be added using plugins just like Filters. Continuation of feat(dashboard): chart customization/dynamic group by in dashboards #33831.
Add deck.gl Layer Visibility chart customization - allows for hiding layers in Multi Layer Deck.gl Chart

Requirements for chart customizations:
Replace current structure (separate "Add filter" / "Add customization" / "Add divider" buttons)
With: Single dropdown button

Button label: "+ New" (secondary button)
Dropdown options:
- Filter
- Customization
- Divider

Add collapsible sections (like dataset folders in Explore):

Section 1: Filters

Contains all filter items
User can reorder items within this section only

Section 2: Customization

Contains all customization controls:
Dynamic group by
Time column
Time grain
Hide layers (deck.gl)

User can reorder items within this section only
Important constraint: Customization controls cannot be moved to Filters section and vice versa

Requirements for Deck.gl Layer Visibility customization:
BY DEFAULT IT’S A MULTISELECT

Functions as an inverse selection filter with multiselect field
By default, all available layers from deck.gl charts are displayed
User selects layers to exclude from charts
Shows tooltip on hover always for this typeomization settings)
Applies to all deck.gl Multiple Layer charts in the dashboard

Design and requirements for reordering layers:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

CodeAnt-AI Description

Unify configuration: edit filters and chart customizations in one modal and persist changes

What Changed

The Filters modal is redesigned to include two collapsible sections (Filters and Customization) with a sidebar and content pane so you can add and edit chart customizations (dynamic group by, time grain, deck.gl layer visibility) alongside native filters in the same place.
Chart customizations are rendered in the filter bar as filter-like controls (cards) — selecting a column or value updates a pending customization state, shows loading/errors while loading dataset columns, and can be required; these pending customization changes are applied together with filters when you click Apply.
Apply now persists pending chart customization changes to the dashboard and triggers chart updates; Clear All resets customization selections and can clear saved customization columns/data masks.
Deck.gl layer visibility is supported as a chart customization and the query schema includes visible_deckgl_layers so multi-layer deck.gl charts respect hidden layers chosen in customization.

Impact

✅ Configure filters and chart customizations from one modal
✅ Persist chart customization changes when applying filters
✅ Hide layers in multi-layer deck.gl charts from dashboard

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

korbit-ai · 2025-11-10T23:45:53Z

Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

bito-code-review · 2025-11-10T23:45:58Z

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

codecov · 2025-11-10T23:54:16Z

Codecov Report

❌ Patch coverage is 82.08955% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.12%. Comparing base (459b4cb) to head (295103b).
⚠️ Report is 41 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/dashboards/api.py	66.66%	9 Missing ⚠️
superset/daos/dashboard.py	88.88%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #36062       +/-   ##
===========================================
+ Coverage        0   68.12%   +68.12%     
===========================================
  Files           0      645      +645     
  Lines           0    48297    +48297     
  Branches        0     5237     +5237     
===========================================
+ Hits            0    32904    +32904     
- Misses          0    14109    +14109     
- Partials        0     1284     +1284

Flag	Coverage Δ
hive	`42.89% <28.35%> (?)`
mysql	`65.96% <82.08%> (?)`
postgres	`66.01% <82.08%> (?)`
presto	`46.47% <28.35%> (?)`
python	`67.91% <82.08%> (?)`
sqlite	`65.73% <82.08%> (?)`
superset-extensions-cli	`94.98% <ø> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR adds Chart Customizations functionality to the dashboard filters modal, enabling users to configure chart-specific customizations (like Time Grain and Time Column) through a unified interface. The implementation includes a plugin-based architecture for extensibility.

Key Changes:

Backend API endpoints for chart customization CRUD operations
Unified filters/customizations modal with collapsible sections
Plugin system for chart customizations (Time Grain, Time Column, Dynamic GroupBy)
Redux state refactoring to consolidate filter and customization management

Reviewed Changes

Copilot reviewed 96 out of 99 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`tests/unit_tests/dashboards/test_chart_customizations_dao.py`	Comprehensive unit tests for chart customization DAO operations
`tests/integration_tests/dashboards/api_tests.py`	API integration tests for customization endpoints
`superset/dashboards/api.py`	New PUT endpoint for chart customizations configuration
`superset/daos/dashboard.py`	DAO method to update chart customizations in dashboard metadata
`superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx`	Major refactor to support both filters and customizations
`superset-frontend/src/dataMask/reducer.ts`	Enhanced data mask handling for chart customizations

Comments suppressed due to low confidence (3)

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/state.ts:1

Comment line removed contains 'TODO' marker without resolution. If the hack is still present, the comment should remain; if resolved, ensure the code is clean.
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx:400
Dataset columns are fetched every time the component renders or dependencies change. Consider memoizing the fetch result or lifting this data fetching to a higher level component to avoid redundant API calls when multiple GroupByFilterCard components use the same dataset.
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx:388
Variable 'datasetSource' is of type date, object or regular expression, but it is compared to an expression of type null.

Copilot · 2025-11-12T18:31:38Z

+        if attributes:
+            metadata = json.loads(dashboard.json_metadata or "{}")


The method doesn't handle the case when attributes is None or empty dict. If attributes is None, the function will return updated_configuration which is undefined, causing an UnboundLocalError. Add validation at the start or initialize updated_configuration = [] before the if attributes: block.

Copilot · 2025-11-12T18:31:40Z

+  const [renderedFilters, setRenderedFilters] = useState<string[]>(
+    initialCurrentFilterId && isFilterId(initialCurrentFilterId)
+      ? [initialCurrentFilterId]
+      : [],
  );


[nitpick] The initialization logic for renderedFilters and renderedCustomizations is duplicated. Consider extracting this into a helper function or consolidating the logic to reduce duplication and improve maintainability.

Copilot · 2025-11-12T18:31:41Z

+  const behaviors = useMemo(
+    () => [
+      isCustomization ? Behavior.ChartCustomization : Behavior.NativeFilter,
+    ],
+    [isCustomization],
+  );


[nitpick] The behaviors array should be defined outside the component or as a constant map since it has only two possible values. Creating a new array on every render (even with useMemo) is unnecessary. Consider: const behaviors = isCustomization ? [Behavior.ChartCustomization] : [Behavior.NativeFilter];

Copilot · 2025-11-12T18:31:41Z

+              const customizationFilterId = (item as { id: string }).id;
+
+              // Only set metadata default if not already loaded from backend
+              const customization = item.customization as {
+                column?: string | string[];
+                defaultDataMask?: { filterState?: { value?: string[] } };
+              };


Multiple type assertions with as suggest the types are not well-defined. Consider defining proper TypeScript interfaces for chart customization items to avoid repeated type casting and improve type safety throughout the codebase.

msyavuz · 2025-11-13T15:55:45Z

+  type: typeof ChartCustomizationType.ChartCustomization;
+  name: string;
+  filterType: string;
+  targets: [Partial<NativeFilterTarget>];


Is this type correct? Is it really a single item in an array?

msyavuz · 2025-11-13T15:58:13Z

+  useEffect(() => {
+    handleChange(defaultValue ?? []);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [JSON.stringify(defaultValue)]);
+
+  useEffect(() => {
+    handleChange(filterState.value ?? []);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [JSON.stringify(filterState.value)]);


Can't we just include handleChange in the dependency array.

It causes infinite re-renders, and I couldn't find a quick solution. This code is from the existing Dynamic Group By feature

kgabryje · 2025-11-19T15:35:14Z

+    mask => mask?.extraFormData?.visible_deckgl_layers !== undefined,
+  );
+
+  const visibleDeckLayersFromRedux =


Can we optimize this with createSelector?

kgabryje · 2025-11-19T15:35:46Z

+      if (!visibleDeckLayers) {
+        visibleDeckLayers = (
+          formData.extra_form_data as ExtraFormData & {
+            visible_deckgl_layers?: number[];


You created a similar type in QueryFormData.ts, can we use that?

codeant-ai-for-open-source · 2026-01-02T12:01:29Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

kgabryje

LGTM

codeant-ai-for-open-source · 2026-01-10T08:24:31Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

netlify · 2026-01-10T08:27:34Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`ca60282`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/696212b176228200081c80b4
😎 Deploy Preview	https://deploy-preview-36062--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…l layers customization

… component

codeant-ai-for-open-source · 2026-01-12T11:42:34Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

vmcs29 · 2026-01-13T18:33:05Z

Hi @DamianPendrak

I have validated this ticket. Looks good on my side.
Thank you!

geido

QA and code review passed. Stamping as a code owner to unblock.

pull-request-size Bot added the size/XXL label Nov 10, 2025

github-actions Bot added api Related to the REST API packages labels Nov 10, 2025

dosubot Bot added change:frontend Requires changing the frontend dashboard:editmode Related to te Dashboard edit mode labels Nov 10, 2025

DamianPendrak force-pushed the filters-and-customizations-modal branch 2 times, most recently from 8818f4d to dc321b6 Compare November 12, 2025 08:47

DamianPendrak requested review from betodealmeida, eschutho, geido, mistercrunch, rusackas and sadpandajoe as code owners November 12, 2025 16:57

sadpandajoe requested review from Copilot and msyavuz November 12, 2025 18:27

Copilot started reviewing on behalf of sadpandajoe November 12, 2025 18:28 View session

Copilot finished reviewing on behalf of sadpandajoe November 12, 2025 18:29

Copilot AI reviewed Nov 12, 2025

View reviewed changes

DamianPendrak force-pushed the filters-and-customizations-modal branch from 651d3bb to a828844 Compare November 13, 2025 09:55

msyavuz reviewed Nov 17, 2025

View reviewed changes

DamianPendrak force-pushed the filters-and-customizations-modal branch 2 times, most recently from 9b5e27f to d57d604 Compare November 19, 2025 10:22

github-actions Bot added the plugins label Nov 19, 2025

DamianPendrak force-pushed the filters-and-customizations-modal branch 2 times, most recently from 69572e9 to ad67edc Compare November 19, 2025 15:21

kgabryje reviewed Nov 19, 2025

View reviewed changes

kgabryje approved these changes Jan 9, 2026

View reviewed changes

DamianPendrak added 19 commits January 12, 2026 12:39

Chart customization

ffe75dc

Customizations out of scope section

61407c0

Fix types

2fa449b

Fix test

835f1f7

Improve filters and customizations scoping

10b1e82

Fix tests

9b987bc

Prettier, tests

49bc392

Scoping update

9c59d5c

Improve filters and customizations scoping

ccd6940

Improve types

dda6d8c

restore filters badge

b97b570

clean up

6d500a1

Fix time grain values sorting

ae26421

Improve dynamic group by card

f7db620

prettier

df2d5af

Remove duplicated abort error handling; Remove debug control in deckg…

a25d7be

…l layers customization

Update the deck slices control description

e588e82

Fix type errors

5e17a90

Resolve indentation and import formatting issues in FiltersConfigForm…

c8411ca

… component

Fix translation imports

295103b

geido approved these changes Jan 14, 2026

View reviewed changes

DamianPendrak mentioned this pull request Jan 15, 2026

fix(chart-customizations): support migration of dynamic group by #37176

Merged

9 tasks

gabotorresruiz mentioned this pull request Feb 3, 2026

test(native-filters): add unit tests for requiredFirst filter logic #37640

Merged

9 tasks

rusackas mentioned this pull request Apr 17, 2026

docs: Superset 6.1 documentation catch-up — batch 4 #39446

Merged

6 tasks

		if attributes:
		metadata = json.loads(dashboard.json_metadata or "{}")

Conversation

DamianPendrak commented Nov 10, 2025 • edited by codeant-ai-for-open-source Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

korbit-ai Bot commented Nov 10, 2025

Uh oh!

bito-code-review Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

msyavuz Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

msyavuz Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

DamianPendrak Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

kgabryje Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kgabryje Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source Bot commented Jan 2, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

kgabryje left a comment

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source Bot commented Jan 10, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

netlify Bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

codeant-ai-for-open-source Bot commented Jan 12, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

vmcs29 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geido left a comment

DamianPendrak commented Nov 10, 2025 •

edited by codeant-ai-for-open-source Bot

Loading

bito-code-review Bot commented Nov 10, 2025 •

edited

Loading

codecov Bot commented Nov 10, 2025 •

edited

Loading

netlify Bot commented Jan 10, 2026 •

edited

Loading

vmcs29 commented Jan 13, 2026 •

edited

Loading