fix(superset-frontend): Fixes for broken functionality when an application root is defined

[martyngigg]

SUMMARY

Fixes for the settings menu:

• includes app root in the link to the user information
• removes old superset/fab_overrides template references. The templates were removed in chore: clean up more flask/jinja html views #34093.
• fixes 'Create chart' button on SQL lab interface in the presence of a non-empty application root

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Fixes #35027

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Empty applicationRoot causes incorrect path stripping ▹ view
	Uncached stripAppRoot call on navigation ▹ view

Files scanned

​

File Path	Reviewed
superset-frontend/src/utils/pathUtils.ts	✅
superset-frontend/src/utils/assetUrl.ts	✅
superset-frontend/src/features/home/Menu.tsx	✅
superset-frontend/src/features/home/RightMenu.tsx	✅
superset-frontend/src/SqlLab/components/ResultSet/index.tsx	✅
superset/views/base.py	✅
superset/security/manager.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.26%. Comparing base (b5cac47) to head (3400127).
⚠️ Report is 594 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #36058       +/-   ##
===========================================
+ Coverage        0   68.26%   +68.26%     
===========================================
  Files           0      629      +629     
  Lines           0    46175    +46175     
  Branches        0     4998     +4998     
===========================================
+ Hits            0    31523    +31523     
- Misses          0    13402    +13402     
- Partials        0     1250     +1250     

Flag	Coverage Δ
hive	43.88% <ø> (?)
mysql	67.38% <ø> (?)
postgres	67.43% <ø> (?)
presto	47.51% <ø> (?)
python	68.23% <ø> (?)
sqlite	67.04% <ø> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR fixes broken functionality when an application root is defined in Superset's configuration by ensuring proper handling of URL paths throughout the frontend and cleaning up obsolete backend template code.

• Adds ensureStaticPrefix utility to conditionally apply static asset prefixes to relative paths
• Fixes "Create chart" button in SQL Lab to correctly handle app roots when opening in new windows vs navigating in-app
• Removes obsolete FAB template widget classes from backend that were orphaned by a previous PR

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
superset/views/base.py	Removes unused SupersetListWidget class and ListWidget import
superset/security/manager.py	Removes unused widget classes (SupersetSecurityListWidget, SupersetRoleListWidget) and their assignments
superset-frontend/src/utils/assetUrl.ts	Adds ensureStaticPrefix function to handle static asset URLs
superset-frontend/src/utils/assetUrl.test.ts	Adds tests for assetUrl and ensureStaticPrefix functions
superset-frontend/src/features/home/RightMenu.tsx	Applies ensureAppRoot to user info URL
superset-frontend/src/features/home/Menu.tsx	Applies ensureStaticPrefix to brand images and ensureAppRoot to brand links
superset-frontend/src/features/home/Menu.test.tsx	Updates test to verify brand image URLs include static assets prefix
superset-frontend/src/explore/exploreUtils/index.js	Adds includeAppRoot parameter to getURIDirectory and mountExploreUrl functions
superset-frontend/src/SqlLab/components/ResultSet/index.tsx	Uses includeAppRoot parameter to correctly handle URLs for new window vs in-app navigation

[martyngigg]

Is there a way I can rerun a single check? I think "[Python-Integration / test-mysql" is flaky?

[rusackas]

Looks like CI passed (yay!) but there's a conflict to resolve (dang!).

[martyngigg]

Looks like CI passed (yay!) but there's a conflict to resolve (dang!).

Thanks for nudge. Should be fixed now.

[martyngigg]

@sadpandajoe Do you think it's possible this could make it into v6?

[martyngigg]

korbit-ai has requested changes but I can't what they are. Their docs link doesn't work to ask for a re-review either. Can anyone help with that?

[rusackas]

LGTM!

[martyngigg]

Thanks for merging :)

[martyngigg]

@sadpandajoe Could this be included in the v6.0 branch?