Skip to content

fix(dashboard): align filter bar elements vertically in horizontal mode #36036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 7 commits into from
Nov 11, 2025
Merged

fix(dashboard): align filter bar elements vertically in horizontal mode #36036

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d9ad39
fix(dashboard): align filter bar elements vertically in horizontal mode
richardfogaca Nov 7, 2025
67b73dc
refactor: add null coallescense to address PR suggestion
richardfogaca Nov 7, 2025
b544713
fix(dashboard): preserve padding for overflowed filters in horizontal…
richardfogaca Nov 7, 2025
d04ce1b
test(dashboard): update horizontal filter bar test for compact filter…
richardfogaca Nov 8, 2025
3a11e86
fix(dashboard): restore spacing for overflow filters in horizontal ba…
richardfogaca Nov 8, 2025
36dbc01
Merge branch 'master' into fix/horizontal-filter-bar-alignment
richardfogaca Nov 10, 2025
1eb1b84
refactor(dashboard): use single theme destructuring in filter title
richardfogaca Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset-frontend/packages/superset-ui-core/src/components/Loading/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ const LoaderWrapper = styled.div<{

&.inline-centered {
margin: 0 auto;
display: block;
display: flex;
align-items: center;
justify-content: center;
}
&.floating {
position: absolute;
Expand Down
1 change: 0 additions & 1 deletion superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ const ActionButtons = ({
<Button
disabled={!isClearAllEnabled}
buttonStyle="link"
buttonSize="small"
className="filter-clear-all-button"
onClick={onClearAll}
{...getFilterBarTestId('clear-button')}
Expand Down
5 changes: 4 additions & 1 deletion ...rontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,16 @@ const VerticalFilterControlTitle = styled.h4`
const HorizontalFilterControlTitle = styled(VerticalFilterControlTitle)`
font-weight: ${({ theme }) => theme.fontWeightNormal};
color: ${({ theme }) => theme.colorText};
margin: 0;
${truncationCSS};
`;

const HorizontalOverflowFilterControlTitle = styled(
HorizontalFilterControlTitle,
)`
max-width: none;
margin: ${({ theme }) => theme.sizeUnit * 2}px 0
Comment thread
richardfogaca marked this conversation as resolved.
Outdated
${({ theme }) => theme.sizeUnit}px;
`;

const VerticalFilterControlTitleBox = styled.div`
Expand Down Expand Up @@ -161,7 +164,7 @@ const HorizontalFormItem = styled(StyledFormItem)<{
align-items: center;
}

.ant-form-item-label {
&& > .ant-row > .ant-form-item-label {
display: flex;
align-items: center;
overflow: visible;
Expand Down
16 changes: 14 additions & 2 deletions ...-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,15 @@ import { useFilterOutlined } from '../useFilterOutlined';
const HEIGHT = 32;

// Overrides superset-ui height with min-height
const StyledDiv = styled.div`
const StyledDiv = styled.div<{
orientation: FilterBarOrientation;
overflow: boolean;
}>`
padding-bottom: ${({ theme, orientation, overflow }) =>
orientation === FilterBarOrientation.Horizontal && !overflow
? 0
: (theme?.sizeUnit ?? 4)}px;

& > div {
height: auto !important;
min-height: ${HEIGHT}px;
Expand Down Expand Up @@ -353,7 +361,11 @@ const FilterValue: FC<FilterControlProps> = ({
}

return (
<StyledDiv data-test="form-item-value">
<StyledDiv
data-test="form-item-value"
orientation={orientation}
overflow={overflow}
>
{isLoading ? (
<Loading position="inline-centered" size="s" muted />
) : (
Expand Down
Loading