Skip to content

chore(deps-dev): bump fetch-mock from 11.1.5 to 12.5.6 in /superset-frontend/packages/superset-ui-core #35905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dependabot wants to merge 2 commits into from
Closed

chore(deps-dev): bump fetch-mock from 11.1.5 to 12.5.6 in /superset-frontend/packages/superset-ui-core #35905

dependabot wants to merge 2 commits into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2025 •
edited by codeant-ai-for-open-source bot
Loading

User description

Bumps fetch-mock from 11.1.5 to 12.5.6.

Release notes

Sourced from fetch-mock's releases.

fetch-mock: v12.5.6

12.5.6 (2025-10-27)

Bug Fixes

  • clean abort event listener once it's called or response is returned (4606250)
  • clean abort event listener once it's called or response is returned (ca51920)

fetch-mock: v12.5.5

12.5.5 (2025-10-21)

Bug Fixes

  • do not try to get a reader from a locked request oder response to cancel them (8c23ecf)
  • use optional chaining operator and do not try to cancel locked request or response to prevent errors (b1ff114)
  • use optional chaining operator to prevent errors (87f8399)

fetch-mock: v12.5.4

12.5.4 (2025-08-28)

Bug Fixes

  • apply browser exports fix for fetch-mock package (318cd94)

fetch-mock: v12.5.3

12.5.3 (2025-06-17)

Bug Fixes

  • add wrapper class to fix type ambiguity (b093bb0)
  • add wrapper class to fix type ambiguity (ea45aec)

fetch-mock: v12.5.2

12.5.2 (2025-03-03)

Bug Fixes

  • allow matching body for delete requests (891197c)

fetch-mock: v12.5.1

12.5.1 (2025-03-01)

Bug Fixes

... (truncated)

Changelog

Sourced from fetch-mock's changelog.

12.5.6 (2025-10-27)

Bug Fixes

  • clean abort event listener once it's called or response is returned (4606250)
  • clean abort event listener once it's called or response is returned (ca51920)

12.5.5 (2025-10-21)

Bug Fixes

  • do not try to get a reader from a locked request oder response to cancel them (8c23ecf)
  • use optional chaining operator and do not try to cancel locked request or response to prevent errors (b1ff114)
  • use optional chaining operator to prevent errors (87f8399)

12.5.4 (2025-08-28)

Bug Fixes

  • apply browser exports fix for fetch-mock package (318cd94)

12.5.3 (2025-06-17)

Bug Fixes

  • add wrapper class to fix type ambiguity (b093bb0)
  • add wrapper class to fix type ambiguity (ea45aec)

12.5.2 (2025-03-03)

Bug Fixes

  • allow matching body for delete requests (891197c)

12.5.1 (2025-03-01)

Bug Fixes

  • improve handling of abort (5c1085d)
  • remove deprecated is-subset-of (a2546ef)

12.5.0 (2025-03-01)

... (truncated)

Commits
  • 346d867 chore: release main
  • ca51920 fix: clean abort event listener once it's called or response is returned
  • e7a29e8 chore: release main
  • 9cdfe9d test: add test for optional chaining for route in call history
  • 8c23ecf fix: do not try to get a reader from a locked request oder response to cancel...
  • 87f8399 fix: use optional chaining operator to prevent errors
  • 0ce27b2 chore: release main
  • 318cd94 fix: apply browser exports fix for fetch-mock package
  • 818d9d2 chore: release main
  • c698670 build: tweak delay tests to deal with circleci clock drift?
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

CodeAnt-AI Description

Update fetch-mock to v12.5.6 in superset-ui-core (dev dependency)

What Changed

  • Tests and local development now use fetch-mock 12.5.6, which stops leaving abort event listeners attached after a request is cancelled or a response is returned
  • Package lock updated; the workspace includes the newer fetch-mock node module
  • Developer machines running frontend tests must meet the package's Node engine requirement (>=18.11.0)

Impact

✅ Fewer flaky tests caused by leftover fetch abort listeners
✅ More reliable fetch cancellation behavior in test suites
✅ Tests and local frontend tooling require Node >=18.11.0

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Oct 30, 2025
@korbit-ai
Copy link

korbit-ai bot commented Oct 30, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@dependabot dependabot bot mentioned this pull request Oct 30, 2025
Closed
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Oct 30, 2025 •
edited
Loading

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@codeant-ai-for-open-source
Copy link
Contributor

codeant-ai-for-open-source bot commented Dec 10, 2025

CodeAnt AI is reviewing your PR.

@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:S This PR changes 10-29 lines, ignoring generated files label Dec 10, 2025
@codeant-ai-for-open-source
Copy link
Contributor

codeant-ai-for-open-source bot commented Dec 10, 2025

CodeAnt AI finished reviewing your PR.

@codeant-ai-for-open-source
Copy link
Contributor

codeant-ai-for-open-source bot commented Dec 10, 2025

💡 Enhance Your PR Reviews

We noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow:

🚦 Quality Gates

Status: Quality Gates are not enabled at the organization level
Learn more about Quality Gates

🎫 Jira Ticket Compliance

Status: Jira credentials file not found. Please configure Jira integration in your settings
Learn more about Jira Integration

⚙️ Custom Rules

Status: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about Custom Rules

Want to enable these features? Contact your organization admin or check our documentation for setup instructions.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 11, 2025

A newer version of fetch-mock exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.5.6 branch from edd97ee to 47d30b6 Compare December 11, 2025 19:14
@codeant-ai-for-open-source
Copy link
Contributor

codeant-ai-for-open-source bot commented Dec 11, 2025

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@rusackas
Copy link
Member

rusackas commented Dec 11, 2025

fetch-mock v12 has breaking API changes that affect tests throughout the codebase. Methods like resetHistory(), calls(), and restore() have changed. Requires comprehensive test updates.

@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.5.6 branch from 47d30b6 to 8e1f993 Compare December 11, 2025 22:13
dependabot bot and others added 2 commits December 11, 2025 15:09
@dependabot @rusackas
chore(deps-dev): bump fetch-mock
0d709ca 
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock/tree/HEAD/packages/fetch-mock) from 11.1.5 to 12.5.6.
- [Release notes](https://github.com/wheresrhys/fetch-mock/releases)
- [Changelog](https://github.com/wheresrhys/fetch-mock/blob/main/packages/fetch-mock/CHANGELOG.md)
- [Commits](https://github.com/wheresrhys/fetch-mock/commits/fetch-mock-v12.5.6/packages/fetch-mock)

---
updated-dependencies:
- dependency-name: fetch-mock
  dependency-version: 12.5.6
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@rusackas @claude
chore: update package-lock.json for fetch-mock 12.5.6
0a129d0 
Regenerate lock file to properly resolve fetch-mock@12.5.6 in
@superset-ui/core workspace package.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.5.6 branch from 8e1f993 to 0a129d0 Compare December 11, 2025 23:09
@rusackas rusackas closed this Dec 12, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.5.6 branch December 12, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependabot dependencies:needs-work dependencies:npm npm Dependabot - npm related PRs packages size:S This PR changes 10-29 lines, ignoring generated files size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rusackas