Skip to content

fix(explore): Overwriting a chart updates the form_data_key #35888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geido merged 2 commits into from
Nov 5, 2025
Merged

fix(explore): Overwriting a chart updates the form_data_key #35888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cfca3a
fix: overwrite chart updates
msyavuz Oct 29, 2025
7693bf2
test: add tests to the fix
msyavuz Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions superset-frontend/src/explore/components/SaveModal.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,3 +315,33 @@ test('make sure slice_id in the URLSearchParams before the redirect', () => {
);
expect(result.get('slice_id')).toEqual('1');
});

test('removes form_data_key from URL parameters after save', () => {
const myProps = {
...defaultProps,
slice: { slice_id: 1, slice_name: 'title', owners: [1] },
actions: {
setFormData: jest.fn(),
updateSlice: jest.fn(() => Promise.resolve({ id: 1 })),
getSliceDashboards: jest.fn(),
},
user: { userId: 1 },
history: {
replace: jest.fn(),
},
dispatch: jest.fn(),
};

const saveModal = new PureSaveModal(myProps);

// Test with form_data_key in the URL
const urlWithFormDataKey = '?form_data_key=12345&other_param=value';
const result = saveModal.handleRedirect(urlWithFormDataKey, { id: 1 });

// form_data_key should be removed
expect(result.has('form_data_key')).toBe(false);
// other parameters should remain
expect(result.get('other_param')).toEqual('value');
expect(result.get('slice_id')).toEqual('1');
expect(result.get('save_action')).toEqual('overwrite');
});
5 changes: 2 additions & 3 deletions superset-frontend/src/explore/components/SaveModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,8 @@ class SaveModal extends Component<SaveModalProps, SaveModalState> {
handleRedirect = (windowLocationSearch: string, chart: any) => {
const searchParams = new URLSearchParams(windowLocationSearch);
searchParams.set('save_action', this.state.action);
if (this.state.action !== 'overwrite') {
searchParams.delete('form_data_key');
}

searchParams.delete('form_data_key');
Copy link
Member

@geido geido Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking. If we now remove this always, is there any intended functionality that we are going to lose?

Copy link
Contributor

@EnxDev EnxDev Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking. If we now remove this always, is there any intended functionality that we are going to lose?

Good question!
Previously, the cached form_data_key could sometimes reference an outdated datasource, causing charts to show stale data after saving changes.
By always removing it, we make sure the chart reloads from the database and reflects the most up-to-date state.
The only minor trade-off is a slightly slower load, but it ensures full data consistency


searchParams.set('slice_id', chart.id.toString());
return searchParams;
Expand Down
Loading