Skip to content

fix(dashboard): dashboard filter was incorrectly showing as out of scope #35886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnxDev merged 12 commits into from
Nov 12, 2025
Merged

fix(dashboard): dashboard filter was incorrectly showing as out of scope #35886

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2171a30
fix: save button was enabled even no changes were made to the dashboa…
richardfogaca Oct 23, 2025
5a94d8a
perf: extract inline handler to prevent unnecessary re-renders
richardfogaca Oct 23, 2025
6fd3bab
refactor: remove redundant else statement
richardfogaca Oct 27, 2025
95d850f
fix(dashboard): dashboard filter was incorrectly showing as out of scope
richardfogaca Oct 29, 2025
0e0c31b
test(dashboard): add tests for filter scope calculation and chartsInS…
richardfogaca Oct 29, 2025
d179452
fix(dashboard): preserve chartsInScope and tabsInScope when updating …
richardfogaca Oct 30, 2025
0e226d1
fix(dashboard): preserve chartsInScope and tabsInScope when updating …
richardfogaca Oct 30, 2025
acf8ef7
Merge branch 'fix/dashboard-filter-shows-as-out-of-scope' of github.c…
richardfogaca Oct 30, 2025
21bc5b4
refactor: improve perf and include unit tests to native filters logic
richardfogaca Oct 30, 2025
47688fa
chore: remove console log
richardfogaca Oct 31, 2025
d7199b2
chore: rollback unrelated changes to the fix
richardfogaca Oct 31, 2025
5d62696
Merge branch 'master' into fix/dashboard-filter-shows-as-out-of-scope
richardfogaca Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ const TOP_OF_PAGE_RANGE = 220;

const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
const nativeFilterScopes = useNativeFilterScopes();
const nativeFilters = useSelector<RootState, Filters>(
state => state.nativeFilters?.filters,
);
const dispatch = useDispatch();

const dashboardLayout = useSelector<RootState, DashboardLayout>(
Expand Down Expand Up @@ -192,7 +195,13 @@ const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
};
});
dispatch(setInScopeStatusOfFilters(scopes));
}, [chartIds, JSON.stringify(nativeFilterScopes), dashboardLayout, dispatch]);
}, [
chartIds,
JSON.stringify(nativeFilterScopes),
dashboardLayout,
dispatch,
JSON.stringify(nativeFilters),
Comment thread
richardfogaca marked this conversation as resolved.
]);

const childIds: string[] = useMemo(
() => (topLevelTabs ? topLevelTabs.children : [DASHBOARD_GRID_ID]),
Expand Down
Loading