Skip to content

fix: saved query preview modal not highlighting active rows #35866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 4 commits into from
Nov 11, 2025
Merged

fix: saved query preview modal not highlighting active rows #35866

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24fe966
fix: clear stuck hover state when opening saved query preview modal
richardfogaca Oct 28, 2025
73abf24
refactor: use useCallback to improve perf
richardfogaca Oct 28, 2025
b33fef9
refactor: remove important selector, add specificity instead
richardfogaca Oct 28, 2025
2f7e353
Merge branch 'master' into fix/saved-queries-not-highlighted-on-navig…
richardfogaca Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ const StyledTable = styled(Table)<{
}
}

.ant-table-row.table-row-highlighted > td.ant-table-cell,
.ant-table-row.table-row-highlighted > td.ant-table-cell.ant-table-cell-row-hover {
background-color: ${theme.colorPrimaryBg};
}

.ant-table-cell {
max-width: 320px;
font-feature-settings: 'tnum' 1;
Expand Down Expand Up @@ -155,6 +160,7 @@ function TableCollection<T extends object>({
columns,
rows,
loading,
highlightRowId,
setSortBy,
headerGroups,
columnsForWrapText,
Expand Down Expand Up @@ -272,6 +278,12 @@ function TableCollection<T extends object>({
onPageChange,
]);

const getRowClassName = useCallback(
(record: Record<string, unknown>) =>
record?.id === highlightRowId ? 'table-row-highlighted' : '',
[highlightRowId],
);

return (
<StyledTable
loading={loading}
Expand All @@ -289,6 +301,7 @@ function TableCollection<T extends object>({
sortDirections={['ascend', 'descend', 'ascend']}
isPaginationSticky={isPaginationSticky}
showRowCount={showRowCount}
rowClassName={getRowClassName}
components={{
header: {
cell: (props: HTMLAttributes<HTMLTableCellElement>) => (
Expand Down
Loading