test(tasks): Add tests for log_task_failure signal handler#35721
Merged
test(tasks): Add tests for log_task_failure signal handler#35721
Conversation
Added unit tests to verify the log_task_failure signal handler: - Test logging with sender task provided - Test logging when sender is None (fallback to "Unknown") Both tests verify the correct logging behavior with proper exception info. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
dosubot
bot
added
the
alert-reports
geido
approved these changes
Oct 18, 2025
sadpandajoe
pushed a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1b6d57c)
sadpandajoe
pushed a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1b6d57c)
sadpandajoe
pushed a commit
that referenced
this pull request
Dec 16, 2025
Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1b6d57c)
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Jan 17, 2026
) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1b6d57c)
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Jan 24, 2026
) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1b6d57c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds test coverage for the
log_task_failuresignal handler that was introduced in #35595.The original PR added the signal handler to log Celery task failures, but did not include tests. This follow-up PR adds comprehensive test coverage for the handler.
Related to #35595
TESTING INSTRUCTIONS
Run the new tests:
Both tests should pass, verifying:
ADDITIONAL INFORMATION