Skip to content

test(dashboard): eliminate race condition in FiltersConfigModal test #35717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadpandajoe merged 1 commit into from
Oct 22, 2025
Merged

test(dashboard): eliminate race condition in FiltersConfigModal test #35717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...end/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,19 +337,21 @@ test.skip('validates the default value', async () => {

test('validates the pre-filter value', async () => {
jest.useFakeTimers();
try {
defaultRender();

defaultRender();
await userEvent.click(screen.getByText(FILTER_SETTINGS_REGEX));
await userEvent.click(getCheckbox(PRE_FILTER_REGEX));

userEvent.click(screen.getByText(FILTER_SETTINGS_REGEX));
userEvent.click(getCheckbox(PRE_FILTER_REGEX));

jest.runOnlyPendingTimers();
jest.useRealTimers();
jest.runAllTimers();
} finally {
jest.useRealTimers();
}

expect(
await screen.findByText(PRE_FILTER_REQUIRED_REGEX),
).toBeInTheDocument();
}, 50000); // Slow-running test, increase timeout to 50 seconds.
await waitFor(() => {
expect(screen.getByText(PRE_FILTER_REQUIRED_REGEX)).toBeInTheDocument();
});
});

// eslint-disable-next-line jest/no-disabled-tests
test.skip("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => {
Expand Down
Loading