Skip to content

Comments

fix(charts): update axis title labels to sentence case#35684

Closed
yousoph wants to merge 1 commit intomasterfrom
fix/axis-title-labels-sentence-case
Closed

fix(charts): update axis title labels to sentence case#35684
yousoph wants to merge 1 commit intomasterfrom
fix/axis-title-labels-sentence-case

Conversation

@yousoph
Copy link
Member

@yousoph yousoph commented Oct 16, 2025

Changed "AXIS TITLE MARGIN" and "AXIS TITLE POSITION" labels from ALL CAPS to proper sentence case in bar and bubble charts.

🤖 Generated with Claude Code

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Changed "AXIS TITLE MARGIN" and "AXIS TITLE POSITION" labels
from ALL CAPS to proper sentence case in bar and bubble charts.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Bubble/controlPanel.tsx
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@sadpandajoe
Copy link
Member

@yousoph are these strings that may need to be updated any of the translation files?

@sadpandajoe sadpandajoe self-requested a review October 16, 2025 18:14
@yousoph
Copy link
Member Author

yousoph commented Oct 17, 2025

#35694

@yousoph yousoph closed this Oct 17, 2025
@dosubot dosubot bot added viz:charts:bar Related to the Bar chart viz:charts:bubble Related to the Bubble chart labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins size/S viz:charts:bar Related to the Bar chart viz:charts:bubble Related to the Bubble chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants