[Fix]: Label generation for grouped by, single metric time series charts#3566
Closed
fabianmenges wants to merge 1 commit intoapache:masterfrom
Closed
[Fix]: Label generation for grouped by, single metric time series charts#3566fabianmenges wants to merge 1 commit intoapache:masterfrom
grouped by, single metric time series charts#3566fabianmenges wants to merge 1 commit intoapache:masterfrom
Conversation
fabianmenges
commented
Oct 2, 2017
| .reduce((distinct, v) => distinct.add(v), new Set()).size; | ||
| // remove the msg key from the label if these conditions are true | ||
| const removeMostSignificant = mostSignificant.length === payload.data.length && | ||
| distinctMostSignificant === 1; |
Contributor
Author
There was a problem hiding this comment.
instead of this (complicated) logic in line 103 to 112 we could simplify how we set the removeMostSignificant flag to:
const removeMostSignificant = slice.formData.metrics.length === 1;
However that would make the label generation depend on the fromData and it would therefore be less generic. Let me know what you think...
Member
|
Sorry about the confusion, I should have created an issue and assigned it to myself. |
Contributor
Author
|
No worries, sorry for all these bugs... naming stuff is hard. |
Member
|
Oh wait sorry about more confusion, I though this was the duplicate fix for the thing I fixed. I knew I had to close that duplicate fix and just assumed this was the PR, wrong one... |
2 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mistercrunch reported a change in behavior/bug introduced in #3504
This addresses the issue.