Skip to content

fix: Log Celery task failures with a signal handler #35595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eschutho merged 2 commits into from
Oct 14, 2025
Merged

fix: Log Celery task failures with a signal handler #35595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a26910
Log Celery task failures with a signal handler
eschutho Oct 10, 2025
69177a6
fix(tasks): Add type hints to scheduler signal handler and task
eschutho Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions superset/tasks/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

from celery import Task
from celery.exceptions import SoftTimeLimitExceeded
from celery.signals import task_failure
from flask import current_app

from superset import is_feature_enabled
Expand All @@ -41,8 +42,32 @@
logger = logging.getLogger(__name__)


@celery_app.task(name="reports.scheduler")
def scheduler() -> None:
@task_failure.connect
def log_task_failure( # pylint: disable=unused-argument
sender: Task | None = None,
task_id: str | None = None,
exception: Exception | None = None,
args: tuple[Any, ...] | None = None,
kwargs: dict[str, Any] | None = None,
traceback: Any = None,
einfo: Any = None,
**kw: Any,
) -> None:
task_name = sender.name if sender else "Unknown"
logger.exception("Celery task %s failed: %s", task_name, exception, exc_info=einfo)


@celery_app.task(
name="reports.scheduler",
bind=True,
autoretry_for=(Exception,),
Copy link
Contributor

@aminghadersohi aminghadersohi Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude SoftTimeLimitExceeded from auto-retry?

Copy link
Member Author

@eschutho eschutho Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I can see a case for either- if it timed out, it's likely to time out again, so why waste resources, but on the other hand, what if the time out was unusual, and it will succeed the next time. What do you think?

retry_kwargs={
"max_retries": 3,
"countdown": 60,
}, # Retry up to 3 times, wait 60s between
retry_backoff=True, # exponential backoff
)
def scheduler(self: Task) -> None: # pylint: disable=unused-argument
"""
Celery beat main scheduler for reports
"""
Expand Down
Loading