Closed
Conversation
xrmx
reviewed
Sep 28, 2017
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
These looks exactly like the inherited postgresql one. I'm not sure the patch is needed
Author
|
yes it's exactly like the postgresql time grains. I added it because on the 0.20, I'm not able anymore to use time grains on redshift. If it's supposed to inherit from postgresl, then it's a bug. is it supposed to do so? |
| class RedshiftEngineSpec(PostgresEngineSpec): | ||
| engine = 'redshift' | ||
|
|
||
| time_grains = ( |
Member
There was a problem hiding this comment.
isn't this inherited from PostgresEngineSpec? Looks like a copy-paste of exactly what is inherited...
Member
|
Did your patch here fix the "bug"? What are the symptoms, is the dropdown empty? |
This was referenced Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.