Explore update button labels #3534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe not clear from their names but from the context where they are placed it shouldn't be hard to sort out what they do though. |
Contributor
Author
|
It's still not obvious when you factor in the location. On the sql editor page, we explicitly state what the button does "Run Query" and "Save Query" to make it clear what you're doing with the query. This should make it more consistent.
|
…mifasubaa/incubator-superset into explore--update_button_labels
Member
|
Our designer approves of these minor changes, mergin' |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* resolve ui ambiguity * resolve button name ambiguity * update test
This was referenced Jun 28, 2023
This was referenced Jul 6, 2023
This was referenced Dec 1, 2023
This was referenced Dec 27, 2023
This was referenced Jan 4, 2024
This was referenced Jan 12, 2024
This was referenced Jan 20, 2024
This was referenced Jan 31, 2024
This was referenced Feb 7, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really clear from the button names the difference between both buttons.
@mistercrunch