Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset/sql/dialects/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@

from .dremio import Dremio
from .firebolt import Firebolt, FireboltOld
from .pinot import Pinot

__all__ = ["Dremio", "Firebolt", "FireboltOld"]
__all__ = ["Dremio", "Firebolt", "FireboltOld", "Pinot"]
43 changes: 43 additions & 0 deletions superset/sql/dialects/pinot.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

"""
MySQL ANSI dialect for Apache Pinot.

This dialect is based on MySQL but follows ANSI SQL quoting conventions where
double quotes are used for identifiers instead of string literals.
"""

from __future__ import annotations

from sqlglot.dialects.mysql import MySQL


class Pinot(MySQL):
"""
MySQL ANSI dialect used by Apache Pinot.

The main difference from standard MySQL is that double quotes (") are used for
identifiers instead of string literals, following ANSI SQL conventions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


See: https://calcite.apache.org/javadocAggregate/org/apache/calcite/config/Lex.html#MYSQL_ANSI
"""

class Tokenizer(MySQL.Tokenizer):
QUOTES = ["'"] # Only single quotes for strings
IDENTIFIERS = ['"', "`"] # Backticks and double quotes for identifiers
STRING_ESCAPES = ["'", "\\"] # Remove double quote from string escapes
Comment on lines +41 to +43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should these have type hints?

class Tokenizer(MySQL.Tokenizer):
      QUOTES: list[str] = ["'"]
      IDENTIFIERS: list[str] = ['"', "`"]
      STRING_ESCAPES: list[str] = ["'", "\\"]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually more idiomatic to not annotate local variables when the type is obvious; so, for example, this is OK:

a: list[str] = []

But not this:

a: list[str] = ["b"]

4 changes: 2 additions & 2 deletions superset/sql/parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
)

from superset.exceptions import QueryClauseValidationException, SupersetParseError
from superset.sql.dialects import Dremio, Firebolt
from superset.sql.dialects import Dremio, Firebolt, Pinot

if TYPE_CHECKING:
from superset.models.core import Database
Expand Down Expand Up @@ -94,7 +94,7 @@
# "odelasticsearch": ???
"oracle": Dialects.ORACLE,
"parseable": Dialects.POSTGRES,
"pinot": Dialects.MYSQL,
"pinot": Pinot,
"postgresql": Dialects.POSTGRES,
"presto": Dialects.PRESTO,
"pydoris": Dialects.DORIS,
Expand Down
Loading
Loading