-
Notifications
You must be signed in to change notification settings - Fork 16.7k
fix: sqlglot dialect for Pinot #35333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| """ | ||
| MySQL ANSI dialect for Apache Pinot. | ||
|
|
||
| This dialect is based on MySQL but follows ANSI SQL quoting conventions where | ||
| double quotes are used for identifiers instead of string literals. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from sqlglot.dialects.mysql import MySQL | ||
|
|
||
|
|
||
| class Pinot(MySQL): | ||
| """ | ||
| MySQL ANSI dialect used by Apache Pinot. | ||
|
|
||
| The main difference from standard MySQL is that double quotes (") are used for | ||
| identifiers instead of string literals, following ANSI SQL conventions. | ||
|
|
||
| See: https://calcite.apache.org/javadocAggregate/org/apache/calcite/config/Lex.html#MYSQL_ANSI | ||
| """ | ||
|
|
||
| class Tokenizer(MySQL.Tokenizer): | ||
| QUOTES = ["'"] # Only single quotes for strings | ||
| IDENTIFIERS = ['"', "`"] # Backticks and double quotes for identifiers | ||
| STRING_ESCAPES = ["'", "\\"] # Remove double quote from string escapes | ||
|
Comment on lines
+41
to
+43
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: should these have type hints?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's actually more idiomatic to not annotate local variables when the type is obvious; so, for example, this is OK: a: list[str] = []But not this: a: list[str] = ["b"] |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a link?
See: https://calcite.apache.org/javadocAggregate/org/apache/calcite/config/Lex.html#MYSQL_ANSI