Skip to content

fix(doris): Don't set supports_cross_catalog_queries to true #35332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 3 commits into from
Sep 30, 2025
+7 −3
Merged

fix(doris): Don't set supports_cross_catalog_queries to true #35332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c271086
fix(doris): don't set supports_cross_catalog_queries to true
msyavuz Sep 29, 2025
9452a58
Update superset/db_engine_specs/doris.py
msyavuz Sep 29, 2025
8022af9
chore: Update dependency
msyavuz Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions requirements/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,10 @@ dnspython==2.7.0
# email-validator
docker==7.0.0
# via apache-superset
duckdb==1.3.2
# via duckdb-engine
duckdb==0.10.3
# via
# apache-superset
# duckdb-engine
Comment on lines +184 to +187
Copy link
Member Author

@msyavuz msyavuz Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of those issues caused by ci not running where it should be. By-catch

duckdb-engine==0.17.0
# via apache-superset
email-validator==2.2.0
Expand Down
4 changes: 3 additions & 1 deletion superset/db_engine_specs/doris.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ class DorisEngineSpec(MySQLEngineSpec):
)
encryption_parameters = {"ssl": "0"}
supports_dynamic_schema = True
supports_catalog = supports_dynamic_catalog = supports_cross_catalog_queries = True
supports_catalog = supports_dynamic_catalog = True
# while technically supported by Doris, this generates invalid table identifiers
supports_cross_catalog_queries = False

column_type_mappings = ( # type: ignore
(
Expand Down
Loading