Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,38 @@ test('Bulk selection should work with pagination', () => {
const checkboxes = screen.getAllByRole('checkbox');
expect(checkboxes.length).toBeGreaterThan(0);
});

test('handleTableChange should convert array field to dot notation for nested fields', () => {
const setSortBy = jest.fn();
const sortingProps = {
...defaultProps,
setSortBy,
};

render(<TableCollection {...sortingProps} />);

// Test the array-to-dot-notation conversion logic directly
const mockArraySorter = {
field: ['database', 'database_name'],
order: 'descend' as const,
};

const mockStringSorter = {
field: 'table_name',
order: 'ascend' as const,
};

// Test array field conversion
const fieldIdArray = Array.isArray(mockArraySorter.field)
? mockArraySorter.field.join('.')
: mockArraySorter.field;

expect(fieldIdArray).toBe('database.database_name');

// Test string field passthrough
const fieldIdString = Array.isArray(mockStringSorter.field)
? mockStringSorter.field.join('.')
: mockStringSorter.field;

expect(fieldIdString).toBe('table_name');
Comment thread
rebenitez1802 marked this conversation as resolved.
Outdated
});
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,14 @@ function TableCollection<T extends object>({
const handleTableChange = useCallback(
(_pagination: any, _filters: any, sorter: SorterResult) => {
if (sorter && sorter.field) {
// Convert array field back to dot notation for nested fields
const fieldId = Array.isArray(sorter.field)
? sorter.field.join('.')
: sorter.field;

setSortBy?.([
{
id: sorter.field,
id: fieldId,
desc: sorter.order === 'descend',
},
] as SortingRule<T>[]);
Expand Down
Loading