Skip to content

fix: defensive code to avoid accesing attribute of a NoneType object #35219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 1 commit into from
Sep 22, 2025
Merged

fix: defensive code to avoid accesing attribute of a NoneType object #35219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset/dashboards/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,6 +1342,8 @@ def thumbnail(self, pk: int, digest: str, **kwargs: Any) -> WerkzeugResponse:
self.incr_stats("from_cache", self.thumbnail.__name__)
try:
image = cache_payload.get_image()
if not image or not hasattr(image, "read"):
return self.response_404()
Comment on lines +1345 to +1346

This comment was marked as resolved.

Sign in to view

except ScreenshotImageNotAvailableException:
return self.response_404()
return Response(
Expand Down
Loading