Skip to content

fix(theming): replace error color with bolt icon for local themes #35090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 1 commit into from
Sep 11, 2025
Merged

fix(theming): replace error color with bolt icon for local themes #35090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/src/hooks/useThemeMenuItems.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ describe('useThemeMenuItems', () => {

it('displays override icon when hasLocalOverride is true', () => {
renderThemeMenu({ ...defaultProps, hasLocalOverride: true });
expect(screen.getByTestId('format-painter')).toBeInTheDocument();
expect(screen.getByTestId('thunderbolt')).toBeInTheDocument();
});

it('renders Theme group header', async () => {
Expand Down
12 changes: 6 additions & 6 deletions superset-frontend/src/hooks/useThemeMenuItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
* under the License.
*/
import { useMemo } from 'react';
import { Icons } from '@superset-ui/core/components';
import { Icons, Tooltip } from '@superset-ui/core/components';
import type { MenuItem } from '@superset-ui/core/components/Menu';
import { t, ThemeMode, useTheme, ThemeAlgorithm } from '@superset-ui/core';
import { t, ThemeMode, ThemeAlgorithm } from '@superset-ui/core';

export interface ThemeSubMenuOption {
key: ThemeMode;
Expand All @@ -43,8 +43,6 @@ export const useThemeMenuItems = ({
onClearLocalSettings,
allowOSPreference = true,
}: ThemeSubMenuProps): MenuItem => {
const theme = useTheme();

const handleSelect = (mode: ThemeMode) => {
setThemeMode(mode);
};
Expand All @@ -63,11 +61,13 @@ export const useThemeMenuItems = ({
const selectedThemeModeIcon = useMemo(
() =>
hasLocalOverride ? (
<Icons.FormatPainterOutlined style={{ color: theme.colorError }} />
<Tooltip title={t('This theme is set locally')} placement="bottom">
<Icons.ThunderboltOutlined />
</Tooltip>
) : (
themeIconMap[themeMode]
),
[hasLocalOverride, theme.colorError, themeIconMap, themeMode],
[hasLocalOverride, themeIconMap, themeMode],
);

const themeOptions: MenuItem[] = [
Expand Down
Loading