Skip to content

fix(theming): more visual bugs #34987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 2 commits into from
Sep 4, 2025
Merged

fix(theming): more visual bugs #34987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b09649a
fix(MarkdownEditor): change theme for contrast
msyavuz Sep 2, 2025
7f6038d
fix(RightMenu): Plus icon same color as others
msyavuz Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,10 +393,7 @@ export const FullSQLEditor = AsyncAceEditor(
},
);

export const MarkdownEditor = AsyncAceEditor([
'mode/markdown',
'theme/textmate',
]);
export const MarkdownEditor = AsyncAceEditor(['mode/markdown', 'theme/github']);

export const TextAreaEditor = AsyncAceEditor([
'mode/markdown',
Expand Down
7 changes: 1 addition & 6 deletions superset-frontend/src/features/home/RightMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,12 +571,7 @@ const RightMenu = ({
if (!navbarRight.user_is_anonymous && showActionDropdown) {
items.push({
key: 'new-dropdown',
label: (
<Icons.PlusOutlined
iconColor={theme.colorPrimary}
data-test="new-dropdown-icon"
/>
),
label: <Icons.PlusOutlined data-test="new-dropdown-icon" />,
className: 'submenu-with-caret',
icon: <Icons.CaretDownOutlined iconSize="xs" />,
children: buildNewDropdownItems(),
Expand Down
Loading