Skip to content

feat: a manager for SQLAlchemy engines#34826

Open
betodealmeida wants to merge 19 commits into
masterfrom
engine-manager
Open

feat: a manager for SQLAlchemy engines#34826
betodealmeida wants to merge 19 commits into
masterfrom
engine-manager

Address comments

75a64b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 15, 2026 in 1s

63.85% (-0.02%) compared to 9459bc7

View this Pull Request on Codecov

63.85% (-0.02%) compared to 9459bc7

Details

Codecov Report

❌ Patch coverage is 83.07692% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.85%. Comparing base (9459bc7) to head (75a64b3).
⚠️ Report is 790 commits behind head on master.

Files with missing lines Patch % Lines
superset/engines/manager.py 79.51% 14 Missing and 3 partials ⚠️
superset/models/core.py 72.72% 2 Missing and 1 partial ⚠️
superset/extensions/engine_manager.py 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34826      +/-   ##
==========================================
- Coverage   63.87%   63.85%   -0.02%     
==========================================
  Files        2582     2585       +3     
  Lines      136418   136768     +350     
  Branches    31454    31531      +77     
==========================================
+ Hits        87137    87339     +202     
- Misses      47768    47911     +143     
- Partials     1513     1518       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.