Skip to content

fix(echarts): Series labels hard to read in dark mode #34815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgabryje merged 1 commit into from
Aug 25, 2025
+7 −0
Merged

fix(echarts): Series labels hard to read in dark mode #34815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ export default function transformProps(
showValueIndexes: showValueIndexesA,
thresholdValues,
timeShiftColor,
theme,
},
);
if (transformedSeries) series.push(transformedSeries);
Expand Down Expand Up @@ -516,6 +517,7 @@ export default function transformProps(
showValueIndexes: showValueIndexesB,
thresholdValues: thresholdValuesB,
timeShiftColor,
theme,
},
);
if (transformedSeries) series.push(transformedSeries);
Expand Down
1 change: 1 addition & 0 deletions superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ export default function transformProps(
lineStyle,
timeCompare: array,
timeShiftColor,
theme,
},
);
if (transformedSeries) {
Expand Down
4 changes: 4 additions & 0 deletions superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ export function transformSeries(
queryIndex?: number;
timeCompare?: string[];
timeShiftColor?: boolean;
theme?: SupersetTheme;
},
): SeriesOption | undefined {
const { name, data } = series;
Expand Down Expand Up @@ -197,6 +198,7 @@ export function transformSeries(
queryIndex = 0,
timeCompare = [],
timeShiftColor,
theme,
} = opts;
const contexts = seriesContexts[name || ''] || [];
const hasForecast =
Expand Down Expand Up @@ -323,6 +325,8 @@ export function transformSeries(
label: {
show: !!showValue,
position: isHorizontal ? 'right' : 'top',
color: theme?.colorText,
textBorderWidth: 0,

This comment was marked as resolved.

Sign in to view

formatter: (params: any) => {
// don't show confidence band value labels, as they're already visible on the tooltip
if (
Expand Down
Loading