Skip to content

fix(DetailsPanel): Applied filters colors #34790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 2 commits into from
Aug 22, 2025
Merged

fix(DetailsPanel): Applied filters colors #34790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24eba74
fix(DetailsPanel): Applied filters colors
msyavuz Aug 21, 2025
c8e4463
chore: add a max-height
msyavuz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { RefObject, useEffect, useRef, KeyboardEvent } from 'react';

import { useSelector } from 'react-redux';
import { t, useTheme } from '@superset-ui/core';
import { Popover } from '@superset-ui/core/components';
import { List, Popover } from '@superset-ui/core/components';
import {
FiltersContainer,
FiltersDetailsContainer,
Expand Down Expand Up @@ -158,14 +158,19 @@ const DetailsPanelPopover = ({
{t('Applied filters (%d)', appliedIndicators.length)}
</SectionName>
<FiltersContainer>
{appliedIndicators.map(indicator => (
<FilterIndicator
ref={el => indicatorRefs.current.push(el)}
key={indicatorKey(indicator)}
indicator={indicator}
onClick={onHighlightFilterSource}
/>
))}
<List
dataSource={appliedIndicators}
Comment thread
msyavuz marked this conversation as resolved.
renderItem={indicator => (
<List.Item>
<FilterIndicator
ref={el => indicatorRefs.current.push(el)}
key={indicatorKey(indicator)}
indicator={indicator}
onClick={onHighlightFilterSource}
/>
</List.Item>
)}
/>
</FiltersContainer>
</div>
) : null}
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const FilterItem = styled.button`

export const FiltersContainer = styled.div`
${({ theme }) => css`
max-height: 60vh;
Comment thread
msyavuz marked this conversation as resolved.
margin-top: ${theme.sizeUnit}px;
&:not(:last-child) {
padding-bottom: ${theme.sizeUnit * 3}px;
Expand All @@ -116,7 +117,7 @@ export const FiltersDetailsContainer = styled.div`
max-width: 300px;
overflow-x: hidden;

color: ${theme.colorBgBase};
color: ${theme.colorText};
`}
`;

Expand Down
Loading