feat: allow drill-to-details to a specific chart (optionaly) configured at the dataset level#34785
Open
mistercrunch wants to merge 13 commits intomasterfrom
Open
feat: allow drill-to-details to a specific chart (optionaly) configured at the dataset level#34785mistercrunch wants to merge 13 commits intomasterfrom
mistercrunch wants to merge 13 commits intomasterfrom
Conversation
mistercrunch
requested review from
betodealmeida,
eschutho,
geido,
kgabryje,
michael-s-molina and
sadpandajoe
as code owners
github-actions
bot
added
risk:db-migration
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/components/Chart/types.ts | ✅ |
| superset/migrations/versions/2025-08-21_01-54_852e99567fe7_.py | ✅ |
| superset-frontend/src/features/datasets/types.ts | ✅ |
| superset/migrations/versions/2025-08-11_12-43_f56ac3accfc9_drill_through_chart_fk.py | ✅ |
| superset-frontend/src/components/Select/ChartSelect.tsx | ✅ |
| superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx | ✅ |
| superset-frontend/src/components/Datasource/DatasourceModal.tsx | ✅ |
| superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx | ✅ |
| superset/datasets/schemas.py | ✅ |
| superset/datasets/api.py | ✅ |
| superset-frontend/src/components/Datasource/DatasourceEditor.jsx | ✅ |
| superset/connectors/sqla/models.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
mistercrunch
changed the title
Contributor
|
@mistercrunch Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
Contributor
|
@mistercrunch Ephemeral environment spinning up at http://44.243.96.179:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
Member
Author
|
While testing, you might hit a weird known issues related to this comment: #23454 (comment) Refreshing the page fixes it, so you may need to refresh the page between saving the dataset with the new drill-to-chart for it to work in the dashboard. |
Member
Author
|
🎪 @unknown Creating ephemeral environment for commit Action: View workflow Building and deploying... Watch the labels for progress updates. |
mistercrunch
force-pushed
the
custom-drillthrough
branch
from
8148a7c to
5ffb332
Compare
mistercrunch
added
the
🎪 ⚡ showtime-trigger-start
github-actions
bot
removed
the
🎪 ⚡ showtime-trigger-start
Contributor
|
Bito Automatic Review Failed - Technical Failure |
Contributor
|
Bito Automatic Review Failed - Technical Failure |
msyavuz
reviewed
Sep 4, 2025
Member
Author
There was a problem hiding this comment.
wasn't, now I'm wondering what's not deterministic in our package.json causing these side effects ...
9 tasks
EMachad0
reviewed
Sep 10, 2025
9 tasks
…and Explore paths Fixes two issues with the drill-through chart configuration: 1. **SelectAsyncControl crash on clear**: Fixed isLabeledValue function to handle null values properly when clearing selections 2. **Missing field in Explore path**: Added drill_through_chart_id to both dataset API response and SqlaTable.data property serialization This ensures the drill-through chart field loads and saves correctly whether accessed from: - Datasets CRUD interface - Explore → Edit Dataset flow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create DashboardContextFormData type for explicit dashboard context contract - Add useDashboardFormData hook to encapsulate complex dashboard filter logic - Simplify DrillDetailPane from 40+ lines to 4 lines using new hook - Fix Edit Chart link to open drill-through chart instead of original chart - Ensure StatefulChart inherits dashboard native filters, colors, and context This ensures drill-through charts get the same dashboard context as regular dashboard charts, providing consistent filter inheritance and user experience. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace manual URL construction in DrillDetailModal with getExploreUrl utility - Refactor ChartSelect to derive props from SelectAsyncControl using ComponentProps - Add comprehensive test coverage for ChartSelect and useDashboardFormData components - Update DatasourceEditor to use allowClear instead of deprecated clearable prop - Use rest pattern for better prop forwarding and type safety 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…archParams Replace manual URL construction with SupersetClient's built-in searchParams support. Rename queryParams prop to searchParams for API alignment and eliminate 12 lines of URL building logic. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…vigation - Only show Edit chart button when drill-through chart is configured - Fix navigation to properly route to explore page instead of dashboard - Use Button href for same-tab navigation (no target="_blank") - Add Dataset.id type definition for URL generation - Update tests to verify link behavior and required dataset properties 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Make Explore button visible only when drill-through chart is configured - Change button text from "Edit chart" to "Explore" for clarity - Fix Explore button to navigate to correct drill-through chart instead of dashboard - Add proper dashboard context resolution using useDashboardFormData hook - Use getFormDataWithDashboardContext for proper filter and context mixing - Simplify StatefulChart rendering with proper formDataOverrides - Generate explore URLs using getExploreUrl with GET method for reliability - Add error handling for URL generation with user-friendly toast messages - Remove duplicate filter conversion logic and use established patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…herited filters - Mark drill-to-detail filters with `isExtra: true` in `getFormDataWithDashboardContext` - Ensures context menu filters (e.g., "drill to details by -> Canada") appear as dashboard-inherited filters rather than chart-native filters in explore page - Maintains consistency with filter bar filters which already display correctly - Updated `getFormDataWithDashboardContext` to accept optional `drillToDetailFilters` parameter 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Simplifies repeated postFormData + mountExploreUrl + dashboard_page_id pattern used across 6+ files by providing a clean, type-safe async utility. Benefits: - DrillDetailModal: 15 lines → 5 lines (67% reduction) - Centralized URL generation logic for better maintainability - Type-safe options parameter for chartId, tabId, dashboardPageId - Comprehensive test coverage with 4 test scenarios - Better error handling and promise chain management Files refactored: - DrillDetailModal: Simplified async URL generation - DrillByModal: Clean promise chain with proper error handling - SqlLab ResultSet: Modern async/await pattern - Added comprehensive utility tests All component tests passing ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mistercrunch
force-pushed
the
custom-drillthrough
branch
from
964fb3e to
d2d2cee
Compare
mistercrunch
removed
🎪 775063a 🚦 running
Member
|
Any hope of getting this one through? It's a pretty awesome feature :D |
|
What can i do to make this PR happen? Please help me to begin, i need it dreadfully for my work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces customizable drill-to-details functionality that allows dataset owners to configure which chart should be used when users drill through from any chart using their dataset.
Problem: Current drill-to-details uses a one-size-fits-all approach showing all columns in a generic table with no customization options.
Solution: Dataset-level drill-to-details customization allowing association of any existing chart as the drill-to-details target.
Key Benefits:
Implementation:
Walkthrough: