Skip to content

fix: Upload CSV as Dataset#34763

Merged
michael-s-molina merged 21 commits into
apache:masterfrom
luizotavio32:upload-csv-fixes
Sep 8, 2025
Merged

fix: Upload CSV as Dataset#34763
michael-s-molina merged 21 commits into
apache:masterfrom
luizotavio32:upload-csv-fixes

Defining error limit to 5 as a constant inside csv_reader

6c6df38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2025 in 0s

72.14% (+11.66%) compared to 76d897e

View this Pull Request on Codecov

72.14% (+11.66%) compared to 76d897e

Details

Codecov Report

❌ Patch coverage is 24.00000% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.14%. Comparing base (76d897e) to head (6c6df38).
⚠️ Report is 2493 commits behind head on master.

Files with missing lines Patch % Lines
superset/commands/database/uploaders/csv_reader.py 22.53% 54 Missing and 1 partial ⚠️
superset/commands/database/uploaders/base.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #34763       +/-   ##
===========================================
+ Coverage   60.48%   72.14%   +11.66%     
===========================================
  Files        1931      586     -1345     
  Lines       76236    42921    -33315     
  Branches     8568     4546     -4022     
===========================================
- Hits        46114    30967    -15147     
+ Misses      28017    10748    -17269     
+ Partials     2105     1206      -899     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.