fix: Use labels in Drill to Detail

[Vitor-Avila]

SUMMARY

This PR improves the Drill to Detail / Drill to Detail By flows to use the column labels.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

1. Define labels to columns in a dataset.
2. Create a chart using it.
3. Confirm that drill to detail render using the column labels.
   Fixes Show dataset column labels in drilling menus #34402

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/hooks/apiResources/datasets.ts	✅
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx	✅
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx	✅
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[msyavuz]

Is this defaulting to undefined correct here? I don't think it makes sense to do this if we are going to assert types below.

[Vitor-Avila]

great catch! I improved this flow in my last commit @msyavuz -- could you please review it again?

[Vitor-Avila]

Hey @michael-s-molina would you be able to quickly test both #34319 and also this one? I'm asking it because I don't have any custom extension for 'load.drillby.options' loaded, but I believe that's the case for Airbnb so I just want to make sure these changes are not affecting that flow.

[msyavuz]

LGTM!