feat(database): add databricks oauth support#34619
feat(database): add databricks oauth support#34619drummerwolli wants to merge 7 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Duplicated OAuth2 Configuration ▹ view | ✅ Fix detected | |
| OAuth Client Secrets Exposed in Config File ▹ view | 🧠 Incorrect | |
| Hardcoded OAuth2 endpoints limit cloud provider support ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/db_engine_specs/databricks.py | ✅ |
| docs/docs/configuration/databases.mdx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| oauth2_authorization_request_uri = ( | ||
| "https://accounts.cloud.databricks.com/oidc/accounts/{}/v1/authorize" | ||
| ) | ||
| oauth2_token_request_uri = ( | ||
| "https://accounts.cloud.databricks.com/oidc/accounts/{}/v1/token" # noqa: S105 | ||
| ) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| oauth2_authorization_request_uri = ( | ||
| "https://accounts.cloud.databricks.com/oidc/accounts/{}/v1/authorize" | ||
| ) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| DATABASE_OAUTH2_CLIENTS = { | ||
| "Databricks (legacy)": { | ||
| "id": "your-databricks-client-id", | ||
| "secret": "your-databricks-client-secret", | ||
| "scope": "sql", | ||
| "authorization_request_uri": "https://accounts.cloud.databricks.com/oidc/accounts/{account_id}/v1/authorize", | ||
| "token_request_uri": "https://accounts.cloud.databricks.com/oidc/accounts/{account_id}/v1/token", | ||
| }, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34619 +/- ##
===========================================
+ Coverage 60.48% 72.17% +11.68%
===========================================
Files 1931 574 -1357
Lines 76236 41921 -34315
Branches 8568 4424 -4144
===========================================
- Hits 46114 30256 -15858
+ Misses 28017 10483 -17534
+ Partials 2105 1182 -923
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm currently testing this internally and will report back here, hence there might not be any visible activity in this PR in the next days. |
SUMMARY
OAuth 2.0 support for Databricks
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
tbd
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION