Skip to content

fix(Table Chart): render null dates properly #34558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 2 commits into from
Sep 9, 2025
Merged

fix(Table Chart): render null dates properly #34558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c2deb
fix(Table Chart): render null dates properly
nicob3y Aug 5, 2025
aa7c036
fix: npm run lint-fix
nicob3y Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ import { formatColumnValue } from './utils/formatValue';
import { PAGE_SIZE_OPTIONS, SERVER_PAGE_SIZE_OPTIONS } from './consts';
import { updateTableOwnState } from './DataTable/utils/externalAPIs';
import getScrollBarSize from './DataTable/utils/getScrollBarSize';
import DateWithFormatter from './utils/DateWithFormatter';

type ValueRange = [number, number];

Expand Down Expand Up @@ -935,7 +936,10 @@ export default function TableChart<D extends DataRecord = DataRecord>(
},
className: [
className,
value == null ? 'dt-is-null' : '',
value == null ||
(value instanceof DateWithFormatter && value.input == null)
? 'dt-is-null'
: '',
isActiveFilterValue(key, value) ? ' dt-is-active-filter' : '',
].join(' '),
tabIndex: 0,
Expand Down
Loading