Skip to content

[explore] show validation error on control panel header #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mistercrunch merged 2 commits into from
Sep 12, 2017
Merged

[explore] show validation error on control panel header #3453

mistercrunch merged 2 commits into from
Sep 12, 2017

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Sep 12, 2017

img

@coveralls
Copy link

coveralls commented Sep 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.118% when pulling 752d8eb on mistercrunch:header_error into 147c12d on apache:master.

@coveralls
Copy link

coveralls commented Sep 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.118% when pulling 112046fa76680faaa3e8e6e9f01a5acc7f26cfcc on mistercrunch:header_error into 147c12d on apache:master.

@coveralls
Copy link

coveralls commented Sep 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.118% when pulling 42dd4d7 on mistercrunch:header_error into 147c12d on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 69.118% when pulling 42dd4d7 on mistercrunch:header_error into 147c12d on apache:master.

graceguo-supercat
graceguo-supercat approved these changes Sep 12, 2017
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit 3e9f797 into apache:master Sep 12, 2017
@mistercrunch mistercrunch deleted the header_error branch September 12, 2017 16:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mistercrunch @coveralls @graceguo-supercat