Skip to content

fix(echart): initial chart animation#34516

Merged
michael-s-molina merged 1 commit intoapache:masterfrom
justinpark:fix--echart-initial-animation
Aug 2, 2025
Merged

fix(echart): initial chart animation#34516
michael-s-molina merged 1 commit intoapache:masterfrom
justinpark:fix--echart-initial-animation

Conversation

@justinpark
Copy link
Member

@justinpark justinpark commented Aug 1, 2025

SUMMARY

During the process of applying the echart locale patch for #31751, superset encountered an issue where the initial animation of all echarts disappeared. This problem occurred because the logic to call handleSizeChange, which was previously located in the component's didMount, was moved to execute immediately after setOptions within a useEffect that has multiple dependencies.
As a result, when the animation was triggered, handleSizeChange caused a re-render, interrupting the animation process.
This commit resolves the issue by moving handleSizeChange back to the mounting phase, ensuring that the initial animation is no longer interrupted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--echart-animation.mov

After:

after--echart-animation.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@michael-s-molina michael-s-molina merged commit 1a7a381 into apache:master Aug 2, 2025
78 of 79 checks passed
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Aug 2, 2025
michael-s-molina pushed a commit that referenced this pull request Aug 2, 2025
LisaHusband pushed a commit to LisaHusband/superset that referenced this pull request Aug 17, 2025
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 6.0.0 First shipped in 6.0.0 labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/XS v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch viz:charts:echarts Related to Echarts 🚢 6.0.0 First shipped in 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants