fix(echart): initial chart animation#34516
Merged
michael-s-molina merged 1 commit intoapache:masterfrom Aug 2, 2025
Merged
Conversation
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
rusackas
approved these changes
Aug 1, 2025
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 2, 2025
(cherry picked from commit 1a7a381)
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
9 tasks
This was referenced Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
During the process of applying the echart locale patch for #31751, superset encountered an issue where the initial animation of all echarts disappeared. This problem occurred because the logic to call
handleSizeChange, which was previously located in the component's didMount, was moved to execute immediately after setOptions within a useEffect that has multiple dependencies.As a result, when the animation was triggered, handleSizeChange caused a re-render, interrupting the animation process.
This commit resolves the issue by moving handleSizeChange back to the mounting phase, ensuring that the initial animation is no longer interrupted.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--echart-animation.mov
After:
after--echart-animation.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION