Fixing the build #3445
Merged
Fixing the build #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 69.118% when pulling 2df97100ea69ee9c573dfe62f989ea48404b9062 on mistercrunch:fix_build into 3dfdde1 on apache:master. |
This addresses long standing issues and hacks around react-map-gl that have been creating all sorts of build issues over time. It appears that recent changes broke things further. This PR upgrades to the latest `react-map-gl` and removes related hacks.
mistercrunch
force-pushed
the
fix_build
branch
from
2df9710 to
fa16f08
Compare
3 similar comments
|
LGTM!! |
ShirmineWang
pushed a commit
to ShirmineWang/incubator-superset
that referenced
this pull request
Jul 2, 2018
npm is really a terriable package manager... Ref: - apache#3445
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses long standing issues and hacks around react-map-gl
that have been creating all sorts of build issues over time. It appears that recent changes broke things further.
This PR upgrades to the latest
react-map-gland removes related hacks.