fix: address numerous long-standing console errors (python & web)#34299
Merged
mistercrunch merged 2 commits intomasterfrom Jul 24, 2025
Merged
fix: address numerous long-standing console errors (python & web)#34299mistercrunch merged 2 commits intomasterfrom
mistercrunch merged 2 commits intomasterfrom
Conversation
uelf.manifest_file
self.manifest_file
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Inappropriate Log Level for Critical Error ▹ view | 🧠 Incorrect | |
| Large inline translation object obscures component logic ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-ag-grid-table/src/consts.ts | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/consts.ts | ✅ |
| superset-frontend/src/components/Chart/MenuItemWithTruncation.tsx | ✅ |
| superset/app.py | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/EmptyState/index.tsx | ✅ |
| superset/db_engine_specs/init.py | ✅ |
| superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
Show resolved
Hide resolved
geido
approved these changes
Jul 24, 2025
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
dankor
pushed a commit
to dankor/superset
that referenced
this pull request
Aug 18, 2025
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analysis
Import Chain Analysis:
Key Finding:
The translation strings in i18n.ts don't appear to be used anywhere. The grep search shows:
(QueryMode.Aggregate) rather than translated strings
referenced elsewhere
Registration vs Usage:
Conclusion:
The i18n.ts file contains translation keys that were likely intended for the ag-grid table plugin but are not
actually used by any components. The addLocaleData() call registers translations that are never looked up, making
this essentially dead code.