fix(databricks): string escaper#34180
Merged
betodealmeida merged 1 commit intomasterfrom Jul 15, 2025
Merged
Conversation
595ec93 to
d0f275b
Compare
d0f275b to
7df1cc0
Compare
Vitor-Avila
approved these changes
Jul 15, 2025
Contributor
Vitor-Avila
left a comment
There was a problem hiding this comment.
Thanks for porting the fix!
ianngech
pushed a commit
to Pesapal-Ltd/superset
that referenced
this pull request
Jul 17, 2025
3 tasks
dankor
pushed a commit
to dankor/superset
that referenced
this pull request
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Databricks SQLAlchemy dialect we use has a bug when escaping single quotes: it doubles the single quote, instead of using a backslash. For example, a value of
O'Harawill be rendered in the SQL asO''Hara, which is correct for most databases, but for Databricks should beO\'Hara.Upgrading to the latest
databricks-sqlalchemypackage fixes the issue, but requires SQLAlchemy 2.x. The 1.x line ofdatabricks-sqlalchemyhas the bug as well. Note, we're using the unnoficialsqlalchemy-databrickspackage instead, so we should consider changing to the 1.x version of the official one.For now, this PR solves the problem by monkeypatching a custom string escaper into the the dialect.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION