Skip to content

Comments

fix(handlebars): remove serverPaginationControlSetRow from control pa…#34016

Merged
msyavuz merged 3 commits intoapache:masterfrom
LisaHusband:fix-issue-29657
Jul 1, 2025
Merged

fix(handlebars): remove serverPaginationControlSetRow from control pa…#34016
msyavuz merged 3 commits intoapache:masterfrom
LisaHusband:fix-issue-29657

Conversation

@LisaHusband
Copy link
Contributor

SUMMARY

fix(handlebars): remove serverPaginationControlSetRow from control panel config

This PR removes the serverPaginationControlSetRow from the Handlebars chart control panel configuration to fix pagination UI issues when "SERVER PAGINATION" option is enabled but has no effect.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
图片
After:
图片

TESTING INSTRUCTIONS

  1. Run Superset and open a Handlebars chart with a dataset exceeding 10 rows.
  2. Verify that the pagination controls related to server pagination do not appear.
  3. Confirm the chart data renders correctly without pagination UI interference.

ADDITIONAL INFORMATION

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Readability Remove commented-out code ▹ view ✅ Fix detected
Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@LisaHusband
Copy link
Contributor Author

Hi @msyavuz
I’ve made the changes as you suggested — removed serverPaginationControlSetRow and its references from plugin-chart-handlebars. Tested it locally and submitted a fresh PR. Thanks a lot for your helpful feedback!

Copy link
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pr! I think we can merge this after cleanup. Feel free to continue work on this pr though, you don't need to close this and open another one.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

@sadpandajoe Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

@sadpandajoe Ephemeral environment spinning up at http://35.92.77.229:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@msyavuz msyavuz merged commit 308007f into apache:master Jul 1, 2025
61 of 62 checks passed
ianngech pushed a commit to Pesapal-Ltd/superset that referenced this pull request Jul 3, 2025
@LisaHusband LisaHusband deleted the fix-issue-29657 branch July 9, 2025 14:39
dankor pushed a commit to dankor/superset that referenced this pull request Aug 18, 2025
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 6.0.0 First shipped in 6.0.0 labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/M viz:charts:handlebars 🚢 6.0.0 First shipped in 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handlebars chart - pagination support

3 participants