Skip to content

[dashboard] adding an option to duplicate slices when "Saving AS" #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mistercrunch merged 2 commits into from
Aug 30, 2017
Merged

[dashboard] adding an option to duplicate slices when "Saving AS" #3391

mistercrunch merged 2 commits into from
Aug 30, 2017

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 29, 2017

screen shot 2017-08-29 at 4 31 42 pm

  • refactored Checkbox out of CheckboxControl
  • added new checkbox on the dashboard save modal
  • allowed backend logic to clone the slices
  • proper new owner assignement

@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 69.214% when pulling 2a5d85f on mistercrunch:save_dash_silces into 42dd64e on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.1%) to 69.214% when pulling 2a5d85f on mistercrunch:save_dash_silces into 42dd64e on apache:master.

@graceguo-supercat
Copy link

graceguo-supercat commented Aug 30, 2017

LGTM

@mistercrunch mistercrunch merged commit e53f303 into apache:master Aug 30, 2017
@mistercrunch mistercrunch deleted the save_dash_silces branch August 30, 2017 21:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mistercrunch @coveralls @graceguo-supercat