fix(theming): Fix visual regressions from theming P4 #33703

EnxDev · 2025-06-05T17:52:20Z

SUMMARY

This pull request makes minor UI tweaks to address regressions caused by the theming project.
The goal is to restore visual consistency and ensure components match the intended design.
No functional logic has been impacted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
After
Before
After
Before
After
Before
After
Before
After
Before
https://github.com/user-attachments/assets/6a2de66c-1c01-47ad-b027-2e1f34cba7a3
After
https://github.com/user-attachments/assets/0771ff27-7efe-4da6-92ed-e3e01283d9b1
Before
After

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai · 2025-06-05T17:52:25Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

…e when running query

…ns-p4

…dd button field

github-actions · 2025-06-10T09:33:46Z

@EnxDev Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset-frontend/src/dashboard/components/DeleteComponentButton.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx	✅
superset-frontend/src/components/Datasource/Field.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx	✅
superset-frontend/src/components/MessageToasts/Toast.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx	✅
superset-frontend/src/dashboard/components/gridComponents/Column.jsx	✅
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.jsx	✅
superset-frontend/src/components/Datasource/CollectionTable.tsx	✅
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx	✅
superset-frontend/cypress-base/cypress/support/directories.ts	✅
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx	✅
superset-frontend/src/components/Datasource/DatasourceEditor.jsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

…ton"

superset-frontend/src/components/Datasource/DatasourceEditor.jsx

msyavuz · 2025-06-10T12:22:33Z

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx

          paddingTop: theme.sizeUnit * 3,
          position: 'sticky',
-          bottom: theme.sizeUnit,
+          marginBottom: theme.sizeUnit * 3,


Is this intended?

I don't think it is. It causes buttons to not be sticky.
Before:

After:

I thought you were referring to the * 3, Good catch!

...et-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx

…anel width

github-actions · 2025-06-11T12:56:22Z

@msyavuz Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

github-actions · 2025-06-11T13:07:30Z

@msyavuz Ephemeral environment spinning up at http://54.202.174.181:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

github-actions · 2025-06-12T08:30:33Z

@EnxDev Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

github-actions · 2025-06-12T08:41:45Z

@EnxDev Ephemeral environment spinning up at http://35.167.61.154:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

msyavuz · 2025-06-12T11:57:46Z

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx

          paddingTop: theme.sizeUnit * 3,
          position: 'sticky',
-          bottom: theme.sizeUnit,
+          marginBottom: theme.sizeUnit * 3,


I don't think it is. It causes buttons to not be sticky.
Before:

After:

msyavuz · 2025-06-12T11:58:16Z

superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx

    await userEvent.type(inputCertifiedBy, 'test');
    await userEvent.type(inputCertDetails, 'test');
-  });
+  }, 60000); // 60 seconds timeout to avoid timeouts


60 seconds is a bit much, if we decide to increase timeout let's do it in smaller increments

I added a 60-second timeout, exactly like it was done in the test right after the one called "can delete columns".
I believe this is just a temporary fix to avoid blocking the tests. The entire test likely needs to be reviewed; for example, some await statements that have no effect should probably be removed.

superset-frontend/src/components/Datasource/Field.tsx

…ns-p4

… test

…ns-p4

mistercrunch

MERGE AWAY!

…void invalid selector error

style(Dashboard): change color and size for setting icon and delete icon

8edb758

pull-request-size bot added the size/S label Jun 5, 2025

EnxDev added change:frontend Requires changing the frontend frontend:refactor Related to refactoring the frontend frontend:refactor:antd5 review:draft labels Jun 5, 2025

EnxDev added 4 commits June 6, 2025 12:37

style(edit dataset modal): change icon colors and adjust error messag…

f628cb9

…e when running query

fix(FiltersConfigModal): adjust the overflow and add margin where needed

22c9d3b

Merge branch 'template_less' into enxdev/fix/theming/visual-regressio…

57364f7

…ns-p4

fix(SqlEditor): font-weight adjustment on Alert component messagge

a4f44f1

pull-request-size bot added size/L and removed size/S labels Jun 6, 2025

EnxDev force-pushed the template_less branch from 6cfe6e0 to 4676f5c Compare June 8, 2025 08:48

EnxDev added 4 commits June 8, 2025 12:36

Merge branch 'template_less' into enxdev/fix/theming/visual-regressio…

eb9a654

…ns-p4

Merge branch 'template_less' into enxdev/fix/theming/visual-regressio…

d9655c4

…ns-p4

refactor(AdhocFilterControl): replace add button and plus icon with a…

50c8885

…dd button field

clean up

e0a13f4

EnxDev requested review from kgabryje and msyavuz June 10, 2025 09:33

EnxDev marked this pull request as ready for review June 10, 2025 09:33

EnxDev requested review from betodealmeida, eschutho, geido, mistercrunch, rusackas and sadpandajoe as code owners June 10, 2025 09:33

EnxDev added testenv-up and removed review:draft labels Jun 10, 2025

korbit-ai bot reviewed Jun 10, 2025

View reviewed changes

EnxDev requested a review from kasiazjc June 10, 2025 09:51

fix(Select): avoid to close the modal when click on "Deselect all but…

f6c3db8

…ton"

msyavuz reviewed Jun 10, 2025

View reviewed changes

fix(FilterConfigure): re-add overflow-auto and slightly reduce left p…

5f1ef3e

…anel width

github-actions bot added the packages label Jun 10, 2025

EnxDev requested a review from msyavuz June 10, 2025 20:27

msyavuz added testenv-up and removed testenv-up labels Jun 11, 2025

fix RTL test

568b95f

EnxDev added testenv-up and removed testenv-up labels Jun 12, 2025

msyavuz reviewed Jun 12, 2025

View reviewed changes

EnxDev and others added 2 commits June 12, 2025 16:15

clean up

05f22e1

Merge branch 'template_less' into enxdev/fix/theming/visual-regressio…

34f2beb

…ns-p4

EnxDev requested a review from msyavuz June 12, 2025 14:27

EnxDev added 3 commits June 12, 2025 17:48

style(PublishedLabel): align label with the contextual elements

d036fe3

fix(DataSourceEditor.test): increase timeout for "can modify columns"…

cdc6843

… test

Merge branch 'template_less' into enxdev/fix/theming/visual-regressio…

d030eb5

…ns-p4

mistercrunch approved these changes Jun 12, 2025

View reviewed changes

lint

daa5b86

msyavuz approved these changes Jun 12, 2025

View reviewed changes

fix(SouthPane.test): use getByText to assert empty result state and a…

d7da0bd

…void invalid selector error

EnxDev merged commit 253a72f into template_less Jun 12, 2025
49 checks passed

EnxDev deleted the enxdev/fix/theming/visual-regressions-p4 branch June 12, 2025 17:50

sadpandajoe removed the testenv-up label Jun 25, 2025

fix(theming): Fix visual regressions from theming P4 #33703

fix(theming): Fix visual regressions from theming P4 #33703

Uh oh!

Conversation

EnxDev commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot commented Jun 5, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

korbit-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

msyavuz Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

msyavuz Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

EnxDev Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

msyavuz Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

msyavuz Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

EnxDev Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mistercrunch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EnxDev commented Jun 5, 2025 •

edited

Loading

EnxDev Jun 12, 2025 •

edited

Loading