Skip to content

chore: update sqlglot dialect map #33701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

chore: update sqlglot dialect map #33701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion superset/sql/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
# "databend": ???
"databricks": Dialects.DATABRICKS,
# "db2": ???
# "denodo": ???
# "dremio": ???
"drill": Dialects.DRILL,
"druid": Dialects.DRUID,
Expand All @@ -72,14 +73,18 @@
"hive": Dialects.HIVE,
# "ibmi": ???
# "impala": ???
# "kustokql": ???
# "kustosql": ???
# "kylin": ???
"mariadb: ": Dialects.MYSQL,
"motherduck": Dialects.DUCKDB,
"mssql": Dialects.TSQL,
"mysql": Dialects.MYSQL,
"netezza": Dialects.POSTGRES,
"oceanbase": Dialects.MYSQL,
Copy link
Contributor

@Vitor-Avila Vitor-Avila Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be ok, googled it and it seems they're aiming for a perfect replacement for MySQL so it should be fully compatible, but who knows 🤷 Don't think it would hold the PR just mentioning

Copy link
Member Author

@betodealmeida betodealmeida Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's my understanding. I think that even if these are not perfect matches it's better than using the generic parser.

# "ocient": ???
# "odelasticsearch": ???
"oracle": Dialects.ORACLE,
"parseable": Dialects.POSTGRES,
Copy link
Contributor

@Vitor-Avila Vitor-Avila Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto here

# "pinot": ???
"postgresql": Dialects.POSTGRES,
"presto": Dialects.PRESTO,
Expand All @@ -95,6 +100,7 @@
"sqlite": Dialects.SQLITE,
"starrocks": Dialects.STARROCKS,
"superset": Dialects.SQLITE,
# "taosws": ???
"teradatasql": Dialects.TERADATA,
"trino": Dialects.TRINO,
"vertica": Dialects.POSTGRES,
Expand Down
Loading