chore(wip): giving migrate-ts a shot #33667

mistercrunch · 2025-06-03T00:16:43Z

A bit of a not-so-dry run for ts-migrate, wanted to see what it would look like.

tsc errors post execution is about 76, which is pretty manageable. If we all decide this is a positive step forward I don't mind fixing the 76 errors.

Main benefits with this approach:

this changes @ts-ignore to @ts-expect-error with specificity about the error that's expected (providing super useful metadata in-code). @ts-expect-error will fail once the issue is fixed, forcing us to clean up those comments. With @ts-ignore, it's common to keep those messages around even when they've been addressed, which isn't good. With the extra metadata, it's easier to grep for certain types of errors for instance, which is positive.
all files auto-migrate to tx/tsx makes it such that you can type a single function in a large module withouth having the burden of migrating the module atomically. This makes it easier for PRs that are touching areas of the codebase to take on typing a single function without the full burden of migrating the module.

NOTE:

there's an issue with some of the generated comments (in jsx specifically) not working on our particular version of ts, ts-migrate is inserting comments in JSX components airbnb/ts-migrate#150, if we decide to move forward I could downgrade typescript momentarily to push this through

Details ->

> [email protected] type
> tsc --noEmit

plugins/legacy-plugin-chart-partition/test/OptionDescription.test.tsx(44,53): error TS1005: '}' expected.
plugins/legacy-plugin-chart-partition/test/OptionDescription.test.tsx(44,62): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(277,57): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(277,81): error TS1381: Unexpected token. Did you mean `{'}'}` or `&rbrace;`?
src/components/Datasource/DatasourceEditor.tsx(294,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(305,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(347,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(380,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(392,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(926,55): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(939,55): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(949,53): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1023,55): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1032,55): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1053,53): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1064,53): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1176,67): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1211,69): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1229,65): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1431,59): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1431,87): error TS1381: Unexpected token. Did you mean `{'}'}` or `&rbrace;`?
src/components/Datasource/DatasourceEditor.tsx(1433,61): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1444,61): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1452,61): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1468,58): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1482,58): error TS1005: '}' expected.
src/components/Datasource/DatasourceEditor.tsx(1494,58): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(112,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(112,82): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(112,90): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(132,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(132,82): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(132,90): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(173,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(173,144): error TS1002: Unterminated string literal.
src/dashboard/components/Dashboard.test.tsx(174,22): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(174,65): error TS1382: Unexpected token. Did you mean `{'>'}` or `&gt;`?
src/dashboard/components/Dashboard.test.tsx(176,13): error TS17002: Expected corresponding JSX closing tag for 'PluginContext.Provider'.
src/dashboard/components/Dashboard.test.tsx(177,9): error TS1005: ',' expected.
src/dashboard/components/Dashboard.test.tsx(177,34): error TS1109: Expression expected.
src/dashboard/components/Dashboard.test.tsx(224,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(224,91): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(269,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(269,144): error TS1002: Unterminated string literal.
src/dashboard/components/Dashboard.test.tsx(270,22): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(270,59): error TS1382: Unexpected token. Did you mean `{'>'}` or `&gt;`?
src/dashboard/components/Dashboard.test.tsx(272,13): error TS17002: Expected corresponding JSX closing tag for 'PluginContext.Provider'.
src/dashboard/components/Dashboard.test.tsx(273,9): error TS1005: ',' expected.
src/dashboard/components/Dashboard.test.tsx(273,34): error TS1109: Expression expected.
src/dashboard/components/Dashboard.test.tsx(292,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(292,144): error TS1002: Unterminated string literal.
src/dashboard/components/Dashboard.test.tsx(293,22): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(293,59): error TS1382: Unexpected token. Did you mean `{'>'}` or `&gt;`?
src/dashboard/components/Dashboard.test.tsx(295,13): error TS17002: Expected corresponding JSX closing tag for 'PluginContext.Provider'.
src/dashboard/components/Dashboard.test.tsx(296,9): error TS1005: ',' expected.
src/dashboard/components/Dashboard.test.tsx(296,34): error TS1109: Expression expected.
src/dashboard/components/Dashboard.test.tsx(315,57): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(315,144): error TS1002: Unterminated string literal.
src/dashboard/components/Dashboard.test.tsx(316,22): error TS1005: '}' expected.
src/dashboard/components/Dashboard.test.tsx(316,59): error TS1382: Unexpected token. Did you mean `{'>'}` or `&gt;`?
src/dashboard/components/Dashboard.test.tsx(318,13): error TS17002: Expected corresponding JSX closing tag for 'PluginContext.Provider'.
src/dashboard/components/Dashboard.test.tsx(319,9): error TS1005: ',' expected.
src/dashboard/components/Dashboard.test.tsx(319,34): error TS1109: Expression expected.
src/dashboard/components/gridComponents/Tabs.tsx(427,104): error TS1005: '}' expected.
src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.tsx(1007,89): error TS1003: Identifier expected.
src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.tsx(1011,93): error TS1003: Identifier expected.
src/explore/components/controls/CollectionControl/index.tsx(126,89): error TS1003: Identifier expected.
src/explore/components/controls/ColorPickerControl.tsx(119,61): error TS1005: '}' expected.
src/explore/components/controls/ColorPickerControl.tsx(121,61): error TS1005: '}' expected.
src/explore/components/controls/DatasourceControl/index.tsx(469,88): error TS1005: '}' expected.
src/explore/components/controls/FixedOrMetricControl/index.tsx(120,98): error TS1003: Identifier expected.
src/explore/components/controls/FixedOrMetricControl/index.tsx(120,110): error TS1005: '}' expected.
src/explore/components/controls/FixedOrMetricControl/index.tsx(121,20): error TS1005: '...' expected.
src/explore/components/controls/FixedOrMetricControl/index.tsx(126,20): error TS1005: '...' expected.
src/explore/components/controls/FixedOrMetricControl/index.tsx(138,17): error TS1003: Identifier expected.
src/explore/components/DatasourcePanel/index.tsx(334,79): error TS1005: '}' expected.

…back

Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Mehmet Salih Yavuz <[email protected]>

…superset-ui-core/src/components` (#33593)

korbit-ai · 2025-06-03T00:16:49Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

mistercrunch added 30 commits March 17, 2025 13:55

feat: messing with the theme

336763f

make Cancel secondary

352aa36

adjusting some buttons

8d36120

fix types/tests

ac81eef

fix unit test

b2b7b89

ts-ignore

22cbec1

fix a few buttons

d131c29

make secondary filled/primary

b575aa6

fix dashboard left panel background-color

6b5d53a

fixing storybook

d15c6d3

set DARK ff to false

4b55a92

switch primary color, keep old hex as comment in case we want to roll…

5faf018

…back

rebased

dbc7db9

echarts

2d461de

fix treemap

7dbe05f

fix sankey theme

f16600e

fix BIG number

48df49d

fixing vizes

83f47d3

minor progress

2f80ebb

merging

e0d86df

fix MoreOutlined button background

b9be692

color

9cb6c3b

more button background

1ca0f34

echarts theming

11bc496

Merge branch 'master' into template_less

b7bc111

some theming fixes

358633e

touchups

31eb105

Merge branch 'master' into template_less

4afbfd1

fix CopyOutlined icon in dataset view to align with sizing

8ce1449

theme toast icons and various cosmetic updates

56e3d16

mistercrunch and others added 21 commits May 15, 2025 10:42

chore: rip antd-v4 from the app! (#33411)

33f2ffd

Merge branch 'master' into template_less

0af5770

fixing package-lock

4070dba

Merge branch 'master' into template_less

20a17be

fix(theming): Duplicate select values bug (#33558)

2979c30

fix: remove all less styling! (#33445)

c279d08

Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Mehmet Salih Yavuz <[email protected]>

fix native filters styling

17ef5b6

fix(theming): Fix visual regressions from theming P2/3 (#33587)

8e48fdb

feat(Login): Migrate login page to frontend (#33255)

58435e3

chore: moving reusable components from src/components to `packages/…

28db9ad

…superset-ui-core/src/components` (#33593)

fix Tooltip-related imports/exports

9c7b676

Merge branch 'master' into template_less

bd77f82

fix type errors

926d2bf

fix unit test live

ef8ba1c

chore: PoC of using ts-migrate

6bfbbbf

more prep

062b793

more config

3880cd5

fix scripts

5c4fcdb

small test

1f2c20f

migrate all

0cecb06

big migration

297515d

github-actions bot added plugins dependencies:npm packages preset-io labels Jun 3, 2025

michael-s-molina added the review:draft label Jun 4, 2025

EnxDev force-pushed the template_less branch from 6cfe6e0 to 4676f5c Compare June 8, 2025 08:48

Base automatically changed from template_less to master June 20, 2025 20:39

mistercrunch closed this Aug 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(wip): giving migrate-ts a shot #33667

chore(wip): giving migrate-ts a shot #33667

Uh oh!

mistercrunch commented Jun 3, 2025 •

edited

Loading

Uh oh!

korbit-ai bot commented Jun 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

chore(wip): giving migrate-ts a shot #33667

chore(wip): giving migrate-ts a shot #33667

Uh oh!

Conversation

mistercrunch commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

korbit-ai bot commented Jun 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mistercrunch commented Jun 3, 2025 •

edited

Loading