fix(AllEntities): Display action buttons according to the user permissions

[Vitor-Avila]

SUMMARY

The All Entities view (/superset/all_entities/?id=${TAG_ID}) was always displaying action buttons (Edit tag and Add tag to entities), regardless if the user had permission to perform these actions or not. This PR makes the visibility of these buttons dynamic.

It also updates the list to only display the Dashboards / Charts / Queries list in case they have any item.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before, the list would include all asset types, even if there are no elements:

Now, the list only includes the asset type that has items:

Also changed the button casing from Edit Tag to Edit tag.

Video demonstrating the other buttons:

Tags.video.mov

TESTING INSTRUCTIONS

Added frontend tests. For manual testing:

1. Access Superset with an admin account.
2. Create a chart.
3. Create two tags.
4. Add one of these tags to the chart.
5. Access Superset with an account that does not have the can_write perm on Tag.
6. Access the Charts menu, and click on the Tag name in the list.
7. Confirm you don't see the Edit tag button.
8. Update the tag ID in the URL to the other tag that is not associated with any items.
9. Confirm you don't see the Add tag to entities button.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Unmemoized Permission Selector ▹ view	🧠 Incorrect

Files scanned

​

File Path	Reviewed
superset/views/all_entities.py	✅
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx	✅
superset-frontend/src/pages/AllEntities/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[kgabryje]

LGTM

[kasiazjc]

this looks great, thanks @Vitor-Avila! 🙏