Skip to content

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geido merged 2 commits into from
May 20, 2025
Merged

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb6e33
added validation for temp Id
rebenitez1802 May 19, 2025
fe57214
Merge branch 'apache:master' into bugfix/86405-SQLLab-Autocomplete-no…
rebenitez1802 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset-frontend/src/SqlLab/components/SqlEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ const SqlEditor: FC<Props> = ({

const SqlFormExtension = extensionsRegistry.get('sqleditor.extension.form');

const isTempId = (value: unknown): boolean => Number.isNaN(Number(value));

This comment was marked as resolved.

Sign in to view


const startQuery = useCallback(
(ctasArg = false, ctas_method = CtasEnum.Table) => {
if (!database) {
Expand Down Expand Up @@ -915,7 +917,7 @@ const SqlEditor: FC<Props> = ({
)}
{isActive && (
<AceEditorWrapper
autocomplete={autocompleteEnabled}
autocomplete={autocompleteEnabled && !isTempId(queryEditor.id)}
onBlur={onSqlChanged}
onChange={onSqlChanged}
queryEditorId={queryEditor.id}
Expand Down
Loading