fix(pivot-table): apply safeHtmlSpan for cells in the pivot table chart

[richardfogaca]

SUMMARY

The Pivot Table chart was not rendering HTML content within its cells. Instead of displaying formatted HTML (e.g., hyperlinks), it showed the raw HTML tags as plain text. This occurred even when the underlying data contained valid HTML strings and the allowRenderHtml prop was set to true.

BEFORE SCREENSHOT

AFTER SCREENSHOT

TESTING INSTRUCTIONS

• This chart export can be imported into Superset to directly observe the issue. But also possible to be reproduced following the steps below:

1. Create or import a Pivot Table chart where the dataset provides HTML content for one or more cells.
2. Configure the chart to use these HTML-containing fields.
3. Observe the rendering of the data cells in the pivot table. The attached chart export can be imported into Superset to directly observe the issue.

ADDITIONAL INFORMATION

• Has associated issue: Pivot table cells not rendering html #33449
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[rusackas]

So I'm a little confused here. I see you have the "Render Columns in HTML" checkbox checked, and it looks like the cells ARE rendering HTML... but it's just not rendering certain tags (e.g. strong)?

[richardfogaca]

So I'm a little confused here. I see you have the "Render Columns in HTML" checkbox checked, and it looks like the cells ARE rendering HTML... but it's just not rendering certain tags (e.g. strong)?

@rusackas Actually the cells do not render html properly, with the exception of country column (this would be a header). In the example you can see a <strong> tag not rendered and also a <em> tag, but other tags are also not rendered like <a>

[rusackas]

This has conflicts, and I think there was a recent PR that tackled the same topic and got merged. Converting to draft for now, but maybe this isn't needed any more?

[msyavuz]

Yeah, i think i fixed this with this . It looks identical to this one. We had a bit of duplicate work so sorry about that!