Skip to content

Conversation

@bestlong
Copy link
Contributor

@bestlong bestlong commented May 2, 2025

fix #33344

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:traditional-chinese labels May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.18%. Comparing base (76d897e) to head (d66aa3d).
⚠️ Report is 2203 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33345       +/-   ##
===========================================
+ Coverage   60.48%   83.18%   +22.69%     
===========================================
  Files        1931      553     -1378     
  Lines       76236    39966    -36270     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    33246    -12868     
+ Misses      28017     6720    -21297     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.25% <ø> (-0.90%) ⬇️
javascript ?
mysql 75.38% <ø> (?)
postgres 75.44% <ø> (?)
presto 52.71% <ø> (-1.10%) ⬇️
python 83.18% <ø> (+19.68%) ⬆️
sqlite 74.94% <ø> (?)
unit 61.30% <ø> (+3.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@rusackas
Copy link
Member

rusackas commented May 2, 2025

@mistercrunch any idea what's up with the CI errors? They seem pretty wide-spread today.

@mistercrunch
Copy link
Member

this should help -> #33354

@rusackas rusackas closed this May 6, 2025
@rusackas rusackas reopened this May 6, 2025
@rusackas
Copy link
Member

rusackas commented May 6, 2025

Closing/reopeening to kick-start CI

@rusackas
Copy link
Member

rusackas commented May 6, 2025

I think this will need a rebase to get the CI to pass (it's stuck on a docker fix that was contributed after this PR opened).

@mistercrunch
Copy link
Member

you'll have to merge the latest master or rebase...

@rusackas rusackas merged commit 871cfe0 into apache:master May 7, 2025
50 checks passed
@bestlong bestlong deleted the fix-zh_TW-placeholders-are-incompatible branch May 8, 2025 13:50
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label May 12, 2025
@mistercrunch mistercrunch added 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:traditional-chinese i18n Namespace | Anything related to localization size/M v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch 🍒 5.0.0 Cherry-picked to 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pybabel compile show many error

4 participants