-
Notifications
You must be signed in to change notification settings - Fork 16.7k
fix: Bump FAB to 5.X #33055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: Bump FAB to 5.X #33055
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
268c75c
chore: Bump FAB to 5.X
dpgaspar 6c43dba
fix tests and remove appbuilder.app refs
dpgaspar 377c140
fix tests
dpgaspar 4361c68
bump to 5.0.0a6
dpgaspar 37ee205
Merge branch 'master' into chore/fab-5.x
dpgaspar 60af434
bump to 5.0.0a6
dpgaspar e7f345f
bump to 5.0.0a7
dpgaspar 57bb783
merge master
dpgaspar 918a261
re add manager.py
dpgaspar 6af1c49
re add manager.py
dpgaspar 00fdf5a
Merge remote-tracking branch 'origin/chore/fab-5.x' into chore/fab-5.x
dpgaspar dfdd5bc
re add manager.py
dpgaspar 56f2ffe
re add manager.py
dpgaspar 898d3d4
re add manager.py
dpgaspar 85bcdfb
bump to 5.0.0a8
dpgaspar 0ec5995
merge and fix conflicts
dpgaspar 52c64e4
adapt to new FAB 5
dpgaspar 0237711
fix deps
dpgaspar 7d0af5c
fix deps
dpgaspar 763319a
fix deps
dpgaspar 69ae9ab
fix add __tablename__ dynamicplugin
dpgaspar 3938241
use 5.0.0a10
dpgaspar 443ac62
fix tests
dpgaspar baeabe8
fix tests
dpgaspar c61bba5
Merge branch 'master' into chore/fab-5.x
dpgaspar a50f5a5
fix
dpgaspar 60e0df0
bump to 5.0.0a11
dpgaspar dc8c946
fix
dpgaspar 3d46421
remove OIDC support
dpgaspar 534354f
fix dynamic plugins
dpgaspar 9068787
fix dynamic plugins
dpgaspar fa95d0d
Merge branch 'master' into chore/fab-5.x
dpgaspar fea39cc
test a12 without mongodb
dpgaspar b40b476
bump to final version
dpgaspar 7621e8f
added updating line regarding OID
dpgaspar e5bc96c
fix lint
dpgaspar 7b9113a
Merge branch 'master' into chore/fab-5.x
sadpandajoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,8 @@ | |
|
|
||
| import celery | ||
| from flask import Flask | ||
| from flask_appbuilder import AppBuilder, SQLA | ||
| from flask_appbuilder import AppBuilder | ||
| from flask_appbuilder.utils.legacy import get_sqla_class | ||
| from flask_caching.backends.base import BaseCache | ||
| from flask_migrate import Migrate | ||
| from flask_talisman import Talisman | ||
|
|
@@ -123,7 +124,7 @@ def init_app(self, app: Flask) -> None: | |
| cache_manager = CacheManager() | ||
| celery_app = celery.Celery() | ||
| csrf = CSRFProtect() | ||
| db = SQLA() # pylint: disable=disallowed-name | ||
| db = get_sqla_class()() | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will allow compatibility for sqlalchemy 1.x and sqlalchemy 2.x at the same time |
||
| _event_logger: dict[str, Any] = {} | ||
| encrypted_field_factory = EncryptedFieldFactory() | ||
| event_logger = LocalProxy(lambda: _event_logger.get("event_logger")) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OID is a legacy protocol.
This is not a secure implementation since it contains several security flaws, for example the JWT is not verified wish is required by the OIDC protocol. Also keycloak use should be possible using OAuth2.