fix(config): correct slack image url in talisman

[v9dev]

SUMMARY

Fixed the configuration file by replacing the incorrect Slack image URL. The previous URL was causing images to not load, even in development mode. This update ensures Slack images now load correctly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A (Only config and documentation changes)

TESTING INSTRUCTIONS

Verify that Slack images now load correctly in the UI.
Review docs/security/security.mdx to confirm the new guide is correctly formatted and informative.

ADDITIONAL INFORMATION

• No UI changes
• No DB migration required
• Improves documentation

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/config.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (76d897e) to head (124c363).
⚠️ Report is 2203 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #32778       +/-   ##
===========================================
+ Coverage   60.48%   83.40%   +22.91%     
===========================================
  Files        1931      549     -1382     
  Lines       76236    39456    -36780     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32908    -13206     
+ Misses      28017     6548    -21469     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.42% <ø> (-0.74%)	⬇️
javascript	?
mysql	75.64% <ø> (?)
postgres	75.71% <ø> (?)
presto	52.90% <ø> (-0.90%)	⬇️
python	83.40% <ø> (+19.89%)	⬆️
sqlite	75.22% <ø> (?)
unit	61.38% <ø> (+3.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mistercrunch]

Thanks for the improvements to the docs. Only thing here is duplicating TALISMAN_CONFIG in both superset/config.py and now in the docs, where they could diverge over time. I ideally we'd be able to reference one from the other.

Let's change superset/config.py to link out to the [new] docs ->

# For more information on setting up Talisman, please refer to
# https://superset.apache.org/docs/configuration/networking-settings/#{link_to_proper_slug}
TALISMAN_CONFIG = {
{...}

[v9dev]

@mistercrunch
I've made the requested changes. Please review again. Thanks!

[v9dev]

change based on comment

[rusackas]

Appriving CI run 🤞

[mistercrunch]

At first I thought we'd be able to remove the intricate config from config.py to keep things DRY, but obviously we need to keep it there, otherwise would be a breaking change