Skip to content

Conversation

@Quatters
Copy link
Contributor

@Quatters Quatters commented Mar 20, 2025

SUMMARY

PR fixes error "An error occurred while importing queries: Error importing saved_queries. Please re-export your file and try importing again".

Fixes #32706

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Go to SQL Lab
  2. Create any query, save it as Saved Query
  3. Go to Saved Query list page
  4. Export query
  5. Import query

Query should be imported without errors.

ADDITIONAL INFORMATION

  • Has associated issue: Error importing saved queries #32706
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Mar 20, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset/queries/saved_queries/schemas.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (76d897e) to head (591bcc3).
⚠️ Report is 2203 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32775       +/-   ##
===========================================
+ Coverage   60.48%   83.40%   +22.91%     
===========================================
  Files        1931      549     -1382     
  Lines       76236    39456    -36780     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32908    -13206     
+ Misses      28017     6548    -21469     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.42% <100.00%> (-0.74%) ⬇️
javascript ?
mysql 75.64% <100.00%> (?)
postgres 75.71% <100.00%> (?)
presto 52.90% <100.00%> (-0.90%) ⬇️
python 83.40% <100.00%> (+19.89%) ⬆️
sqlite 75.22% <100.00%> (?)
unit 61.38% <100.00%> (+3.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@villebro villebro requested a review from betodealmeida March 20, 2025 16:33
@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Mar 20, 2025
@github-actions
Copy link
Contributor

@Antonio-RiveroMartnez Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

@github-actions
Copy link
Contributor

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.215.63.219:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for fixing this!

@betodealmeida betodealmeida merged commit 5866f3e into apache:master Mar 20, 2025
63 checks passed
@Quatters Quatters deleted the issues/32706-import-query-error branch March 20, 2025 21:35
@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Mar 25, 2025
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Mar 25, 2025
michael-s-molina pushed a commit that referenced this pull request Mar 25, 2025
Co-authored-by: Vladislav Koren'kov <korenkov.vv@dns-shop.ru>
(cherry picked from commit 5866f3e)
michael-s-molina pushed a commit that referenced this pull request Apr 14, 2025
Co-authored-by: Vladislav Koren'kov <korenkov.vv@dns-shop.ru>
(cherry picked from commit 5866f3e)
alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025
Co-authored-by: Vladislav Koren'kov <korenkov.vv@dns-shop.ru>
(cherry picked from commit 5866f3e)
@mistercrunch mistercrunch added 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS sqllab Namespace | Anything related to the SQL Lab v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch 🍒 5.0.0 Cherry-picked to 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error importing saved queries

6 participants