Skip to content

Conversation

@justinpark
Copy link
Member

SUMMARY

This commit includes the tobymao/sqlglot#4672 to fix the JSON_QUERY syntax error in trino.

TESTING INSTRUCTIONS

It should run the following trino query without errors.

SELECT
      id,
      json_query(description, 'strict $.comment' WITH ARRAY WRAPPER) AS with_array,
      json_query(description, 'strict $.comment' WITHOUT ARRAY WRAPPER) AS without_array
FROM customers

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (76d897e) to head (b729b7d).
Report is 1661 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32601       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      548     -1383     
  Lines       76236    39359    -36877     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32848    -13266     
+ Misses      28017     6511    -21506     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.18% <ø> (-0.98%) ⬇️
javascript ?
mysql 74.83% <ø> (?)
postgres 74.85% <ø> (?)
presto 51.75% <ø> (-2.05%) ⬇️
python 83.33% <ø> (+19.82%) ⬆️
sqlite 74.27% <ø> (?)
unit 61.10% <ø> (+3.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinpark
Copy link
Member Author

close in favor of #32745

@justinpark justinpark closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant