chore: Caching the Slack channels list #32529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
alert-reports
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Silent error handling in Slack API call ▹ view | |
 |
Missing Cache Timeout in Slack Channels Cache ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/utils/slack.py | ✅ |
| superset/reports/api.py | ✅ |
| superset-frontend/src/features/alerts/components/NotificationMethod.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
3 tasks
Antonio-RiveroMartnez
approved these changes
Mar 6, 2025
Vitor-Avila
commented
Mar 6, 2025
| limit=limit, | ||
| extra_params=extra_params, | ||
| force=force, | ||
| cache_timeout=86400, |
Contributor
Author
There was a problem hiding this comment.
Hardcoded here for a day, which I think should be generally good. I could make this a dynamic config in a follow up if we think it's better.
eschutho
approved these changes
Mar 6, 2025
sadpandajoe
added
the
review:checkpoint
3 tasks
sadpandajoe
removed
the
review:checkpoint
9 tasks
8 tasks
alexandrusoare
pushed a commit
to alexandrusoare/superset
that referenced
this pull request
Jun 19, 2025
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> (cherry picked from commit 9ad9ea6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Slack API used via the SDK to retrieve channels has a 20+ requests/minute rate limit, which can be hit pretty fast for large Organizations (there's no filtering in the search, so all channels are parsed with a max of 999 items per page).
Since this request might be executed several times (and in parallel) while reports are getting migrated to V2, this PR implements caching for the list with 1d duration. It also adds a force refresh button the UI dropdown (thanks @eschutho 🙏 ).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION