fix(com/grid-comp/markdown): pin remark-gfm to v3 to allow inline code block by backticks in Markdown
#32420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode block by backticks in Markdown Signed-off-by: hainenber <dotronghai96@gmail.com>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
dosubot
bot
added
the
dashboard:markdown
…-gfm` until reaching React 18 Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
kgabryje,
mistercrunch,
nytai,
rusackas and
villebro
as code owners
michael-s-molina
added
the
v5.0
michael-s-molina
pushed a commit
that referenced
this pull request
Mar 5, 2025
…ode block by backticks in Markdown (#32420) Signed-off-by: hainenber <dotronghai96@gmail.com>
michael-s-molina
pushed a commit
that referenced
this pull request
Mar 5, 2025
…ode block by backticks in Markdown (#32420) Signed-off-by: hainenber <dotronghai96@gmail.com>
mistercrunch
added
🍒 5.0.0
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Dec 3, 2025
This commit addresses a critical dependency incompatibility that causes the "Cannot set properties of undefined (setting 'inTable')" error when rendering tables in Markdown components. ## Problem - remark-gfm v4.0.1 requires remark-parser v11+ (unified v11) - react-markdown v8.0.7 uses remark-parser v10 (unified v10) - This version mismatch breaks table rendering in Markdown components ## Solution 1. Downgraded remark-gfm from ^4.0.1 to ^3.0.1 in @superset-ui/core 2. Added npm override in root package.json to prevent auto-upgrades 3. Regenerated package-lock.json to reflect the downgrade ## Related Issues - This issue was previously fixed in PR apache#32420 (March 2025) - Dependabot re-introduced the bug by auto-bumping to v4.0.1 (July 2025) - The npm override prevents this from happening again ## Alternative Solution Upgrading to react-markdown v9+ would allow remark-gfm v4+, but that would be a larger change requiring broader testing. ## Testing Tables in Markdown components now render correctly without errors.
9 tasks
9 tasks
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 7, 2026
Add automated tests to prevent future dependency upgrades from breaking markdown rendering functionality. These tests will fail if remark-gfm is upgraded to v4+ without upgrading react-markdown to v9+ (requires React 18). Tests cover: 1. **Table rendering** - The critical regression from PR apache#32945 - Verifies tables render without "Cannot set properties of undefined" error - Tests table structure (headers, rows, cells) 2. **Inline code blocks** - Original issue from PR apache#32420 (apache#32416) - Ensures backticks work correctly 3. **Additional GFM features** - Comprehensive coverage - Strikethrough text - Task lists with checkboxes 4. **Complex integration** - Real-world scenario - Multiple GFM features together - Mimics actual dashboard markdown usage Each test includes detailed comments explaining: - Why remark-gfm is pinned to v3 - The dependency compatibility constraints - Historical context (PRs apache#32420, apache#32945) - What will break if upgraded incorrectly These tests address reviewer concerns from @sadpandajoe about preventing future breakage and demonstrating the root cause of the incompatibility.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 8, 2026
This commit addresses a critical dependency incompatibility that causes the "Cannot set properties of undefined (setting 'inTable')" error when rendering tables in Markdown components. ## Problem - remark-gfm v4.0.1 requires remark-parser v11+ (unified v11) - react-markdown v8.0.7 uses remark-parser v10 (unified v10) - This version mismatch breaks table rendering in Markdown components ## Solution 1. Downgraded remark-gfm from ^4.0.1 to ^3.0.1 in @superset-ui/core 2. Added npm override in root package.json to prevent auto-upgrades 3. Regenerated package-lock.json to reflect the downgrade ## Related Issues - This issue was previously fixed in PR apache#32420 (March 2025) - Dependabot re-introduced the bug by auto-bumping to v4.0.1 (July 2025) - The npm override prevents this from happening again ## Alternative Solution Upgrading to react-markdown v9+ would allow remark-gfm v4+, but that would be a larger change requiring broader testing. ## Testing Tables in Markdown components now render correctly without errors.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 8, 2026
Add automated tests to prevent future dependency upgrades from breaking markdown rendering functionality. These tests will fail if remark-gfm is upgraded to v4+ without upgrading react-markdown to v9+ (requires React 18). Tests cover: 1. **Table rendering** - The critical regression from PR apache#32945 - Verifies tables render without "Cannot set properties of undefined" error - Tests table structure (headers, rows, cells) 2. **Inline code blocks** - Original issue from PR apache#32420 (apache#32416) - Ensures backticks work correctly 3. **Additional GFM features** - Comprehensive coverage - Strikethrough text - Task lists with checkboxes 4. **Complex integration** - Real-world scenario - Multiple GFM features together - Mimics actual dashboard markdown usage Each test includes detailed comments explaining: - Why remark-gfm is pinned to v3 - The dependency compatibility constraints - Historical context (PRs apache#32420, apache#32945) - What will break if upgraded incorrectly These tests address reviewer concerns from @sadpandajoe about preventing future breakage and demonstrating the root cause of the incompatibility.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 12, 2026
This commit addresses a critical dependency incompatibility that causes the "Cannot set properties of undefined (setting 'inTable')" error when rendering tables in Markdown components. ## Problem - remark-gfm v4.0.1 requires remark-parser v11+ (unified v11) - react-markdown v8.0.7 uses remark-parser v10 (unified v10) - This version mismatch breaks table rendering in Markdown components ## Solution 1. Downgraded remark-gfm from ^4.0.1 to ^3.0.1 in @superset-ui/core 2. Added npm override in root package.json to prevent auto-upgrades 3. Regenerated package-lock.json to reflect the downgrade ## Related Issues - This issue was previously fixed in PR apache#32420 (March 2025) - Dependabot re-introduced the bug by auto-bumping to v4.0.1 (July 2025) - The npm override prevents this from happening again ## Alternative Solution Upgrading to react-markdown v9+ would allow remark-gfm v4+, but that would be a larger change requiring broader testing. ## Testing Tables in Markdown components now render correctly without errors.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 12, 2026
Add automated tests to prevent future dependency upgrades from breaking markdown rendering functionality. These tests will fail if remark-gfm is upgraded to v4+ without upgrading react-markdown to v9+ (requires React 18). Tests cover: 1. **Table rendering** - The critical regression from PR apache#32945 - Verifies tables render without "Cannot set properties of undefined" error - Tests table structure (headers, rows, cells) 2. **Inline code blocks** - Original issue from PR apache#32420 (apache#32416) - Ensures backticks work correctly 3. **Additional GFM features** - Comprehensive coverage - Strikethrough text - Task lists with checkboxes 4. **Complex integration** - Real-world scenario - Multiple GFM features together - Mimics actual dashboard markdown usage Each test includes detailed comments explaining: - Why remark-gfm is pinned to v3 - The dependency compatibility constraints - Historical context (PRs apache#32420, apache#32945) - What will break if upgraded incorrectly These tests address reviewer concerns from @sadpandajoe about preventing future breakage and demonstrating the root cause of the incompatibility.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 14, 2026
This commit addresses a critical dependency incompatibility that causes the "Cannot set properties of undefined (setting 'inTable')" error when rendering tables in Markdown components. ## Problem - remark-gfm v4.0.1 requires remark-parser v11+ (unified v11) - react-markdown v8.0.7 uses remark-parser v10 (unified v10) - This version mismatch breaks table rendering in Markdown components ## Solution 1. Downgraded remark-gfm from ^4.0.1 to ^3.0.1 in @superset-ui/core 2. Added npm override in root package.json to prevent auto-upgrades 3. Regenerated package-lock.json to reflect the downgrade ## Related Issues - This issue was previously fixed in PR apache#32420 (March 2025) - Dependabot re-introduced the bug by auto-bumping to v4.0.1 (July 2025) - The npm override prevents this from happening again ## Alternative Solution Upgrading to react-markdown v9+ would allow remark-gfm v4+, but that would be a larger change requiring broader testing. ## Testing Tables in Markdown components now render correctly without errors.
rebenitez1802
added a commit
to rebenitez1802/superset
that referenced
this pull request
Jan 14, 2026
Add automated tests to prevent future dependency upgrades from breaking markdown rendering functionality. These tests will fail if remark-gfm is upgraded to v4+ without upgrading react-markdown to v9+ (requires React 18). Tests cover: 1. **Table rendering** - The critical regression from PR apache#32945 - Verifies tables render without "Cannot set properties of undefined" error - Tests table structure (headers, rows, cells) 2. **Inline code blocks** - Original issue from PR apache#32420 (apache#32416) - Ensures backticks work correctly 3. **Additional GFM features** - Comprehensive coverage - Strikethrough text - Task lists with checkboxes 4. **Complex integration** - Real-world scenario - Multiple GFM features together - Mimics actual dashboard markdown usage Each test includes detailed comments explaining: - Why remark-gfm is pinned to v3 - The dependency compatibility constraints - Historical context (PRs apache#32420, apache#32945) - What will break if upgraded incorrectly These tests address reviewer concerns from @sadpandajoe about preventing future breakage and demonstrating the root cause of the incompatibility.
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(com/grid-comp/markdown): pin
remark-gfmto v3 to allow inline code block by backticks in MarkdownSUMMARY
Fixes #32416
According to this
remark-gfmissue post,react-markdownv8 (current version in Superset) only plays well withremark-gfmv3, hence the downgrade. The other alternative is to upgradereact-markdownto v9 but that has breaking change of React 18 requirement.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Screen.Recording.2025-02-28.at.12.24.40.mov
After
https://github.com/user-attachments/assets/5d861226-c98f-4687-b9e8-8e90da2a847a
TESTING INSTRUCTIONS
Sales dashboardexample dashboardVehicle Sales DashboardMarkdown section.ADDITIONAL INFORMATION