Skip to content

feat: run prettier before eslint in pre-commit hooks#31984

Merged
mistercrunch merged 1 commit intomasterfrom
prettier_first
Jan 24, 2025
Merged

feat: run prettier before eslint in pre-commit hooks#31984
mistercrunch merged 1 commit intomasterfrom
prettier_first

Conversation

@mistercrunch
Copy link
Member

Simply changing the ordering here as prettier is set to mutate/fix things, and eslint simply logs and errors out, often duplicating messaging on a single issues. Running prettier first makes more sense here.

Simply changing the ordering here as prettier is set to mutate/fix things, and eslint simply
logs and errors out, often duplicating messaging on a single issues. Running prettier first
makes more sense here.
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@mistercrunch
Copy link
Member Author

Related if we want to add tsx pre-commit checks -> microsoft/TypeScript#27379 (comment)

@mistercrunch mistercrunch merged commit 925938b into master Jan 24, 2025
41 of 42 checks passed
@mistercrunch mistercrunch deleted the prettier_first branch January 24, 2025 19:34
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants