fix: add catalog to cache key when getting tables/views

[betodealmeida]

SUMMARY

The cache key for get_all_table_names_in_schema and get_all_view_names_in_schema doesn't include the catalog.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Fix Detected
	Cache key not handling None catalog properly ▹ view

Files scanned

​

File Path	Reviewed
superset/models/core.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[korbit-ai]

Cache key not handling None catalog properly

Tell me more

What is the issue?

The cache key for get_all_table_names_in_schema uses {catalog} even when catalog is None, which could cause cache conflicts for databases not supporting catalogs.

Why this matters

When catalog support is not enabled for a database (allow_multi_catalog=False), passing None as catalog could still create different cache keys, defeating the caching mechanism's purpose and potentially causing unnecessary database queries.

Suggested change ∙ Feature Preview

Modify the cache key to only include catalog when it's not None or when the database supports multi-catalog:

@cache_util.memoized_func(
    key=lambda self, catalog, schema: 
        f"db:{self.id}:" + 
        (f"catalog:{catalog}:" if catalog and self.allow_multi_catalog else "") + 
        f"schema:{schema}:table_list",
    cache=cache_manager.cache,
)

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

[villebro]

Oof! LGTM. I wish we had unit tests for this logic.

[betodealmeida]

Oof! LGTM. I wish we had unit tests for this logic.

One thing I want to do is write a CI action that checks if the return value of cached functions has changed, and warns in the PR that the cache needs to be purged. We could also make it check if all arguments are used in the cache key.